Add top-level driver and abstract plugin superclass

Add top-level driver and abstract plugin superclass

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/81397c00aa0234ee8e35675a28a598083031bc74

[Brian Wilkerson, 2017-01-31 21:16:51]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-01-31 21:27:02]

LGTM

https://codereview.chromium.org/2667823003/diff/1/pkg/analyzer_plugin/lib/plu...
File pkg/analyzer_plugin/lib/plugin/plugin.dart (right):

https://codereview.chromium.org/2667823003/diff/1/pkg/analyzer_plugin/lib/plu...
pkg/analyzer_plugin/lib/plugin/plugin.dart:57: final ByteStore byteStore = new
MemoryByteStore();
Will it be injected?
I guess we want to share analysis results across the server, plugins and
sessions.

[Brian Wilkerson, 2017-01-31 21:37:09]

https://codereview.chromium.org/2667823003/diff/1/pkg/analyzer_plugin/lib/plu...
File pkg/analyzer_plugin/lib/plugin/plugin.dart (right):

https://codereview.chromium.org/2667823003/diff/1/pkg/analyzer_plugin/lib/plu...
pkg/analyzer_plugin/lib/plugin/plugin.dart:57: final ByteStore byteStore = new
MemoryByteStore();
I assume you mean that the on-disk data should be shared, in which case I agree.
In order to do that we'll need to add the location of the disk storage to the
API, probably as part of the 'plugin.versionCheck' request. Does that seem
reasonable?

[scheglov, 2017-01-31 21:41:17]

https://codereview.chromium.org/2667823003/diff/1/pkg/analyzer_plugin/lib/plu...
File pkg/analyzer_plugin/lib/plugin/plugin.dart (right):

https://codereview.chromium.org/2667823003/diff/1/pkg/analyzer_plugin/lib/plu...
pkg/analyzer_plugin/lib/plugin/plugin.dart:57: final ByteStore byteStore = new
MemoryByteStore();
On 2017/01/31 21:37:09, Brian Wilkerson wrote:
> I assume you mean that the on-disk data should be shared, in which case I
agree.
> In order to do that we'll need to add the location of the disk storage to the
> API, probably as part of the 'plugin.versionCheck' request. Does that seem
> reasonable?

SGTM

[Brian Wilkerson, 2017-01-31 21:42:00]

Description was changed from

==========
Add top-level driver and abstract plugin superclass
==========

to

==========
Add top-level driver and abstract plugin superclass

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/81397c00aa0234ee8e35675a28a598083031bc74
==========

[Brian Wilkerson, 2017-01-31 21:42:02]

Committed patchset #1 (id:1) manually as
81397c00aa0234ee8e35675a28a598083031bc74 (presubmit successful).