Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 2667813002: Optimize StackTrace.current Eliminate redundant call to captureStackTrace and compute the stack tra… (Closed)

Created:
3 years, 10 months ago by Jacob
Modified:
3 years, 10 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org, vsm, nweiz
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Optimize StackTrace.current Eliminate redundant call to captureStackTrace and compute the stack trace without throwing an exception on more browsers. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/ac5a77e3a19850a561fd1d8fe6fdf89477c65993

Patch Set 1 #

Patch Set 2 : Do not commit. LineSplitter hack. #

Total comments: 1

Patch Set 3 : for discussion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -244 lines) Patch
M sdk/lib/_internal/js_runtime/lib/core_patch.dart View 1 chunk +6 lines, -5 lines 0 comments Download
M sdk/lib/convert/line_splitter.dart View 1 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 8 chunks +1 line, -235 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jacob
This should speedup runtime performance for Dart2JS applications that capture async stack traces considerably. The ...
3 years, 10 months ago (2017-01-30 23:31:36 UTC) #2
sra1
lgtm
3 years, 10 months ago (2017-01-30 23:39:35 UTC) #3
Jacob
Committed patchset #1 (id:1) manually as ac5a77e3a19850a561fd1d8fe6fdf89477c65993 (presubmit successful).
3 years, 10 months ago (2017-01-30 23:46:32 UTC) #5
Jacob
3 years, 10 months ago (2017-02-03 19:20:19 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/2667813002/diff/20001/sdk/lib/_internal/js_ru...
File sdk/lib/_internal/js_runtime/lib/core_patch.dart (right):

https://codereview.chromium.org/2667813002/diff/20001/sdk/lib/_internal/js_ru...
sdk/lib/_internal/js_runtime/lib/core_patch.dart:700: // Fallback if new
Error().stack does not exist.
Ignore this file. Unrelated

Powered by Google App Engine
This is Rietveld 408576698