chrome/browser/ui/browser_dialogs.h - Issue 2667803002: Picker takes a vector of pairs, and passes back the user chosen target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_dialogs.h

Issue 2667803002: Picker takes a vector of pairs, and passes back the user chosen target. (Closed)

Patch Set: Move replacing of placeholders to after picker Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_dialogs.h

diff --git a/chrome/browser/ui/browser_dialogs.h b/chrome/browser/ui/browser_dialogs.h

index 73dd8e384156b006a45d0fa5a316de5fe393f7c0..3a139b818a2ed0308a13a275b8af07a1a504f637 100644

--- a/chrome/browser/ui/browser_dialogs.h

+++ b/chrome/browser/ui/browser_dialogs.h

@@ -10,9 +10,9 @@

#include <vector>

#include "base/callback.h"

+#include "base/optional.h"

#include "build/build_config.h"

#include "chrome/browser/ui/bookmarks/bookmark_editor.h"

-#include "chrome/browser/webshare/share_service_impl.h"

#include "third_party/skia/include/core/SkColor.h"

#include "ui/gfx/native_widget_types.h"

@@ -160,7 +160,7 @@ void ShowPaymentRequestDialog(payments::PaymentRequest* request);

void ShowWebShareTargetPickerDialog(

gfx::NativeWindow parent_window,

const std::vector<base::string16>& targets,

- const base::Callback<void(SharePickerResult)>& callback);

+ const base::Callback<void(base::Optional<base::string16>)>& callback);

#if defined(OS_MACOSX)