Chromium Code Reviews| Index: chrome/browser/ui/browser_dialogs.h |
| diff --git a/chrome/browser/ui/browser_dialogs.h b/chrome/browser/ui/browser_dialogs.h |
| index 2cdf3e1ee738966c8ad0ab7da083a080a545c388..ce54abd444ecd3f5d8b453a22383ddd985305da5 100644 |
| --- a/chrome/browser/ui/browser_dialogs.h |
| +++ b/chrome/browser/ui/browser_dialogs.h |
| @@ -10,9 +10,10 @@ |
| #include <vector> |
| #include "base/callback.h" |
| +#include "base/optional.h" |
| +#include "base/strings/string16.h" |
| #include "build/build_config.h" |
| #include "chrome/browser/ui/bookmarks/bookmark_editor.h" |
| -#include "chrome/browser/webshare/share_service_impl.h" |
| #include "third_party/skia/include/core/SkColor.h" |
| #include "ui/gfx/native_widget_types.h" |
| @@ -159,13 +160,13 @@ payments::PaymentRequestDialog* CreatePaymentRequestDialog( |
| payments::PaymentRequest* request); |
| // Shows the dialog to choose a share target app. |targets| is a list of app |
| -// titles that will be shown in a list. Calls |callback| with SHARE if an app |
| -// was chosen, or CANCEL if the dialog was cancelled. |
| -// TODO(mgiuca): Callback should provide info about the picked app. |
| +// titles that will be shown in a list. If the user picks a target, this calls |
| +// |callback| with the manifest URL of the chosen target, and returns null if |
|
Matt Giuca
2017/02/01 07:04:33
s/and/or.
constantina
2017/02/01 23:24:20
Done.
|
| +// the user cancelled the share. |
| void ShowWebShareTargetPickerDialog( |
| gfx::NativeWindow parent_window, |
| const std::vector<base::string16>& targets, |
| - const base::Callback<void(SharePickerResult)>& callback); |
| + const base::Callback<void(base::Optional<base::string16>)>& callback); |
| #if defined(OS_MACOSX) |