Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/browser/webshare/share_service_impl.cc

Issue 2667803002: Picker takes a vector of pairs, and passes back the user chosen target. (Closed)
Patch Set: Fix things that slipped through rebase cracks Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/webshare/share_service_impl.cc
diff --git a/chrome/browser/webshare/share_service_impl.cc b/chrome/browser/webshare/share_service_impl.cc
index 051bb65c364dad989fdb1038e1723e73991d76d0..d9d160698704c365d436a820147bbe35270e61e4 100644
--- a/chrome/browser/webshare/share_service_impl.cc
+++ b/chrome/browser/webshare/share_service_impl.cc
@@ -115,7 +115,7 @@ bool ShareServiceImpl::ReplacePlaceholders(base::StringPiece url_template,
void ShareServiceImpl::ShowPickerDialog(
const std::vector<base::string16>& targets,
- const base::Callback<void(SharePickerResult)>& callback) {
+ const base::Callback<void(base::Optional<base::string16>)>& callback) {
// TODO(mgiuca): Get the browser window as |parent_window|.
#if defined(OS_LINUX) || defined(OS_WIN)
chrome::ShowWebShareTargetPickerDialog(nullptr /* parent_window */, targets,
@@ -139,8 +139,8 @@ void ShareServiceImpl::Share(const std::string& title,
const GURL& share_url,
const ShareCallback& callback) {
// TODO(constantina): Replace hard-coded name with the registered target list.
- constexpr char kTargetName[] = "Web Share Target Test App";
- std::vector<base::string16> targets{base::ASCIIToUTF16(kTargetName)};
+ constexpr char kUrlBase[] = "https://wicg.github.io/web-share-target/demos/";
+ std::vector<base::string16> targets{base::ASCIIToUTF16(kUrlBase)};
ShowPickerDialog(targets, base::Bind(&ShareServiceImpl::OnPickerClosed,
base::Unretained(this), title, text,
@@ -151,16 +151,14 @@ void ShareServiceImpl::OnPickerClosed(const std::string& title,
const std::string& text,
const GURL& share_url,
const ShareCallback& callback,
- SharePickerResult result) {
- if (result == SharePickerResult::CANCEL) {
+ base::Optional<base::string16> result) {
+ if (!result.has_value()) {
callback.Run(base::Optional<std::string>("Share was cancelled"));
return;
}
- // TODO(constantina): replace hard-coded URL with one from user-chosen site.
- constexpr char kUrlBase[] = "https://wicg.github.io/web-share-target/";
constexpr char kUrlTemplate[] =
- "demos/sharetarget.html?title={title}&text={text}&url={url}";
+ "sharetarget.html?title={title}&text={text}&url={url}";
std::string url_template_filled;
if (!ReplacePlaceholders(kUrlTemplate, title, text, share_url,
@@ -170,7 +168,8 @@ void ShareServiceImpl::OnPickerClosed(const std::string& title,
return;
}
- GURL target_url(kUrlBase + url_template_filled);
+ std::string url_base = base::UTF16ToASCII(result.value());
+ GURL target_url(url_base + url_template_filled);
if (!target_url.is_valid()) {
callback.Run(base::Optional<std::string>(
"Error: url of share target is not a valid url."));

Powered by Google App Engine
This is Rietveld 408576698