Picker takes a vector of pairs, and passes back the user chosen target.

chrome/browser/webshare/share_service_impl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/run_loop.h"
+#include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/webshare/share_service_impl.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "mojo/public/cpp/bindings/interface_request.h"
 #include "mojo/public/cpp/bindings/strong_binding.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 namespace {
 
 constexpr char kTitle[] = "My title";
 constexpr char kText[] = "My text";
 constexpr char kUrlSpec[] = "https://www.google.com/";
 
 class ShareServiceTestImpl : public ShareServiceImpl {
  public:
   static ShareServiceTestImpl* Create(
       blink::mojom::ShareServiceRequest request) {
     std::unique_ptr<ShareServiceTestImpl> share_service_helper =
         base::MakeUnique<ShareServiceTestImpl>();
     ShareServiceTestImpl* share_service_helper_raw = share_service_helper.get();
     mojo::MakeStrongBinding(std::move(share_service_helper),
                             std::move(request));
     return share_service_helper_raw;
   }
 
-  void set_picker_result(SharePickerResult result) {
+  void set_picker_result(base::Optional<std::string> result) {
     picker_result_ = result;
   }
 
   const std::string& GetLastUsedTargetURL() { return last_used_target_url_; }
 
  private:
-  SharePickerResult picker_result_ = SharePickerResult::SHARE;
+  base::Optional<std::string> picker_result_;
   std::string last_used_target_url_;
 
   void ShowPickerDialog(
-      const std::vector<base::string16>& targets,
-      const base::Callback<void(SharePickerResult)>& callback) override {
+      const std::vector<std::pair<base::string16, GURL>>& targets,
+      const base::Callback<void(base::Optional<std::string>)>& callback)
+      override {
     callback.Run(picker_result_);
   }
 
   void OpenTargetURL(const GURL& target_url) override {
     last_used_target_url_ = target_url.spec();
   }
 };
 
 class ShareServiceImplUnittest : public ChromeRenderViewHostTestHarness {
  public:
@@ skipping 27 matching lines @@
 
 }  // namespace
 
 // Basic test to check the Share method calls the callback with the expected
 // parameters.
 TEST_F(ShareServiceImplUnittest, ShareCallbackParams) {
   std::string expected_url =
       "https://wicg.github.io/web-share-target/demos/"
       "sharetarget.html?title=My%20title&text=My%20text&url=https%3A%2F%2Fwww."
       "google.com%2F";
+  share_service_helper_->set_picker_result(base::Optional<std::string>(
+      "https://wicg.github.io/web-share-target/demos/"));
 
   const GURL url(kUrlSpec);
   base::Callback<void(const base::Optional<std::string>&)> callback =
       base::Bind(&ShareServiceImplUnittest::DidShare, base::Unretained(this),
                  expected_url, base::Optional<std::string>());
 
   base::RunLoop run_loop;
   on_callback_ = run_loop.QuitClosure();
 
   share_service_->Share(kTitle, kText, url, callback);
 
   run_loop.Run();
 }
 
 // Tests the result of cancelling the share in the picker UI.
 TEST_F(ShareServiceImplUnittest, ShareCancel) {
-  // Ask that the dialog be cancelled.
-  share_service_helper_->set_picker_result(SharePickerResult::CANCEL);
-
+  // picker_result_ is set to nullopt by default, so this imitates the user
+  // cancelling a share.
   // Expect an error message in response.
   base::Callback<void(const base::Optional<std::string>&)> callback =
       base::Bind(&ShareServiceImplUnittest::DidShare, base::Unretained(this),
                  std::string(),
                  base::Optional<std::string>("Share was cancelled"));
 
   base::RunLoop run_loop;
   on_callback_ = run_loop.QuitClosure();
 
   const GURL url(kUrlSpec);
@@ skipping 198 matching lines @@
   EXPECT_TRUE(succeeded);
   EXPECT_EQ("%C3%A9", url_template_filled);
 
   // U+1F4A9
   url_template = "{title}";
   succeeded = ShareServiceImpl::ReplacePlaceholders(
       url_template, "\xf0\x9f\x92\xa9", kText, url, &url_template_filled);
   EXPECT_TRUE(succeeded);
   EXPECT_EQ("%F0%9F%92%A9", url_template_filled);
 }