Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 26678003: Remove several unused Node methods (Closed)

Created:
7 years, 2 months ago by Inactive
Modified:
7 years, 2 months ago
Reviewers:
eseidel
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Remove several unused Node methods Remove several unused Node methods that merely call the corresponding implementation in Element: - hasLocalName() - hasAttributes() - attributes() R=eseidel BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159344

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M Source/core/dom/Element.h View 1 chunk +0 lines, -15 lines 0 comments Download
M Source/core/dom/Node.h View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
7 years, 2 months ago (2013-10-09 19:53:58 UTC) #1
eseidel
Really? These are never called on a Node*?
7 years, 2 months ago (2013-10-09 20:05:50 UTC) #2
Inactive
On 2013/10/09 20:05:50, eseidel wrote: > Really? These are never called on a Node*? They ...
7 years, 2 months ago (2013-10-10 13:55:59 UTC) #3
eseidel
lgtm
7 years, 2 months ago (2013-10-10 15:18:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/26678003/1
7 years, 2 months ago (2013-10-10 15:18:43 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-10 16:18:18 UTC) #6
Message was sent while issue was closed.
Change committed as 159344

Powered by Google App Engine
This is Rietveld 408576698