Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2667793003: Remove dart2js_incremental. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2999 lines) Patch
D pkg/dart2js_incremental/lib/caching_compiler.dart View 1 chunk +0 lines, -189 lines 0 comments Download
D pkg/dart2js_incremental/lib/compiler.dart View 1 chunk +0 lines, -211 lines 0 comments Download
D pkg/dart2js_incremental/lib/dart2js_incremental.dart View 1 chunk +0 lines, -176 lines 0 comments Download
D pkg/dart2js_incremental/lib/diff.dart View 1 chunk +0 lines, -122 lines 0 comments Download
D pkg/dart2js_incremental/lib/library_updater.dart View 1 chunk +0 lines, -1521 lines 0 comments Download
D pkg/dart2js_incremental/lib/server.dart View 1 chunk +0 lines, -301 lines 0 comments Download
D pkg/dart2js_incremental/lib/src/options.dart View 1 chunk +0 lines, -134 lines 0 comments Download
D pkg/dart2js_incremental/lib/watcher.dart View 1 chunk +0 lines, -62 lines 0 comments Download
D tests/compiler/dart2js/incremental/compile_all.dart View 1 chunk +0 lines, -179 lines 0 comments Download
D tests/compiler/dart2js/incremental/hello_test.dart View 1 chunk +0 lines, -104 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
TBR, already reviewed as part of CL 2647343003.
3 years, 10 months ago (2017-01-31 15:31:47 UTC) #2
ahe
Committed patchset #1 (id:1) manually as 35d4cccd05223c5438477e2a34068bbf6d15cdfc (presubmit successful).
3 years, 10 months ago (2017-01-31 15:32:29 UTC) #4
Siggi Cherem (dart-lang)
3 years, 10 months ago (2017-01-31 16:36:45 UTC) #5
Message was sent while issue was closed.
lgtm!

Thanks Peter - we (dart2js-team) should follow up by removing all code inside
dart2js that depends on the incremental option as well.

Powered by Google App Engine
This is Rietveld 408576698