chrome/browser/ui/sync/one_click_signin_sync_starter.cc - Issue 2667773003: [reland] MacViews: Allow the toolkit-views Enterprise Signin Confirmation Dialog to be used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_starter.cc

Issue 2667773003: [reland] MacViews: Allow the toolkit-views Enterprise Signin Confirmation Dialog to be used (Closed)

Patch Set: clearer comment Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/sync/one_click_signin_sync_starter.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc

index 1ad06fa1388fdcb3f05f7298e16dc039152d9d95..4933765a42b53401e0e44982cd35ca3b7b3609b4 100644

--- a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc

+++ b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc

@@ -241,11 +241,11 @@ void OneClickSigninSyncStarter::OnRegisteredForPolicy(

content::RecordAction(

base::UserMetricsAction("Signin_Show_EnterpriseAccountPrompt"));

- TabDialogs::FromWebContents(web_contents)->ShowProfileSigninConfirmation(

- browser_,

- profile_,

- signin->GetUsernameForAuthInProgress(),

- new SigninDialogDelegate(weak_pointer_factory_.GetWeakPtr()));

+ TabDialogs::FromWebContents(web_contents)

+ ->ShowProfileSigninConfirmation(browser_, profile_,

+ signin->GetUsernameForAuthInProgress(),

+ base::MakeUnique<SigninDialogDelegate>(

+ weak_pointer_factory_.GetWeakPtr()));

}

void OneClickSigninSyncStarter::LoadPolicyWithCachedCredentials() {

« no previous file with comments | « chrome/browser/ui/collected_cookies_browsertest.cc ('k') | chrome/browser/ui/tab_dialogs.h » ('j') | no next file with comments »