[reland] MacViews: Allow the toolkit-views Enterprise Signin Confirmation Dialog to be used

chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views_browsertest.cc

Index: chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views_browsertest.cc
diff --git a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views_browsertest.cc b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..dcd7437745f3b54b1b5b8a03ed0f9f37816c8554
--- /dev/null
+++ b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views_browsertest.cc
@@ -0,0 +1,75 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h"
+
+#include "base/command_line.h"
+#include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/bookmarks/bookmark_model_factory.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/sync/profile_signin_confirmation_helper.h"
+#include "chrome/browser/ui/tab_dialogs.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/test/test_browser_dialog.h"
+#include "components/bookmarks/browser/bookmark_model.h"
+#include "ui/base/ui_base_switches.h"
+
+namespace {
+
+// Test delegate passed to the confirmation dialog to report back the result.

[msw, 2017/02/09 18:09:54]

nit: "to report back the result"? Seems like this does nothing?

[tapted, 2017/02/09 23:16:10]

ah, it allows the dialog to report. Or the delegate to receive the result :). I
agree the current wording is confusing - updated to:

// Test delegate passed to the confirmation dialog to receive (and currently
// ignore) the result from the dialog.

+class TestSigninDialogDelegate : public ui::ProfileSigninConfirmationDelegate {
+ public:
+  TestSigninDialogDelegate() {}
+  virtual ~TestSigninDialogDelegate() {}
+
+  void OnCancelSignin() override {}
+  void OnContinueSignin() override {}
+  void OnSigninWithNewProfile() override {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(TestSigninDialogDelegate);
+};
+
+}  // namespace
+
+class ProfileSigninConfirmationDialogTest : public DialogBrowserTest {
+ public:
+  ProfileSigninConfirmationDialogTest() {}
+
+  // content::BrowserTestBase:
+  void SetUpCommandLine(base::CommandLine* command_line) override {
+    command_line->AppendSwitch(switches::kExtendMdToSecondaryUi);
+  }
+
+  // DialogBrowserTest:
+  void ShowDialog(const std::string& name) override {
+    Profile* profile = browser()->profile();
+
+    // Add a bookmark to ensure CheckShouldPromptForNewProfile() returns true.
+    bookmarks::BookmarkModel* bookmarks =
+        BookmarkModelFactory::GetForBrowserContext(profile);
+    bookmarks->AddURL(bookmarks->bookmark_bar_node(), 0,
+                      base::ASCIIToUTF16("title"),
+                      GURL("http://www.example.com"));
+
+    content::WebContents* web_contents =
+        browser()->tab_strip_model()->GetActiveWebContents();
+    TabDialogs::FromWebContents(web_contents)
+        ->ShowProfileSigninConfirmation(
+            browser(), profile, "username@example.com",
+            base::MakeUnique<TestSigninDialogDelegate>());
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ProfileSigninConfirmationDialogTest);
+};
+
+// Test that calls ShowDialog("default"). Interactive when run via
+// browser_tests --gtest_filter=BrowserDialogTest.Invoke --interactive
+// --dialog=ProfileSigninConfirmationDialogTest.InvokeDialog_default
+IN_PROC_BROWSER_TEST_F(ProfileSigninConfirmationDialogTest,
+                       InvokeDialog_default) {
+  RunDialog();
+}