Make new target for vector icon structs to replace ui/gfx/vector_icons/

ui/vector_icons/BUILD.gn

+# Copyright 2016 The Chromium Authors. All rights reserved.

[sky, 2017/02/03 16:20:06]

2017

[Evan Stade, 2017/02/03 18:35:01]

Done.

+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+action("aggregate_vector_icons") {
+  visibility = [ ":*" ]
+
+  script = "//ui/gfx/vector_icons/aggregate_vector_icons.py"
+
+  icons = [

[sky, 2017/02/03 16:20:06]

Beyond the icons, is there anything different between this and the other similar
files? Can you use a template to minimize the copying?

[Evan Stade, 2017/02/03 18:35:01]

Yes, this stanza is a bit repetitive, but more often than not it's part of
another target instead of its own file. I don't know how to cut down on the
repetition. Perhaps  we can add a template like grit() (defined in
//tools/grit/grit_rule.gni)?

+thakis to weigh in

[Nico, 2017/02/03 18:40:16]

It's possible to use a template for this, if that's the question :-) There are
many examples, several pretty small:
https://cs.chromium.org/search/?q=template%5C(+file:%5C.gn+package:%5Echromiu...

+    "close.1x.icon",
+    "close.icon",
+  ]
+
+  output_cc = "$target_gen_dir/vector_icons.cc"
+  output_h = "$target_gen_dir/vector_icons.h"
+
+  inputs = icons
+  inputs += [
+    "vector_icons.cc.template",
+    "vector_icons.h.template",
+  ]
+  outputs = [
+    output_cc,
+    output_h,
+  ]
+
+  response_file_contents = rebase_path(icons, root_build_dir)
+
+  args = [
+    "--working_directory=" + rebase_path("./"),
+    "--file_list={{response_file_name}}",
+    "--output_cc=" + rebase_path(output_cc, root_build_dir),
+    "--output_h=" + rebase_path(output_h, root_build_dir),
+  ]
+}
+
+static_library("vector_icons") {
+  sources = get_target_outputs(":aggregate_vector_icons")
+  sources += [ "//ui/gfx/vector_icon_types.h" ]
+
+  deps = [
+    ":aggregate_vector_icons",
+    "//base",
+    "//skia",
+  ]
+}