Surfaced native heap memory allocation information to the Observatory

Surfaced native heap memory allocation information to the Observatory

BUG=
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/c8e275537dd9288a423c3a432d417379a49c6a4a

[bkonyi, 2017-01-31 23:12:52]

Description was changed from

==========
Surfaced native heap memory allocation information to the Observatory and
display it on the VM page.

BUG=
==========

to

==========
Surfaced native heap memory allocation information to the Observatory and
display it on the VM page.

BUG=
==========

[bkonyi, 2017-01-31 23:13:26]

Description was changed from

==========
Surfaced native heap memory allocation information to the Observatory and
display it on the VM page.

BUG=
==========

to

==========
Surfaced native heap memory allocation information to the Observatory

BUG=
==========

[bkonyi, 2017-01-31 23:13:26]

bkonyi@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2017-01-31 23:21:05]

LGTM w/c

https://codereview.chromium.org/2667743004/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/2667743004/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:3805: jsobj.AddProperty("_heapAllocatedMemoryUsage",
if there is a way to detect if the malloc hooks are running, it is more standard
to do:

if (MallocHooks::Initialized()) {
  // add properties.
}

[bkonyi, 2017-01-31 23:37:06]

https://codereview.chromium.org/2667743004/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/2667743004/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:3805: jsobj.AddProperty("_heapAllocatedMemoryUsage",
On 2017/01/31 23:21:05, Cutch wrote:
> if there is a way to detect if the malloc hooks are running, it is more
standard
> to do:
> 
> if (MallocHooks::Initialized()) {
>   // add properties.
> }

I've gone ahead and added MallocHooks::Initialized() since it was a rather quick
change.

[bkonyi, 2017-02-01 00:09:57]

Description was changed from

==========
Surfaced native heap memory allocation information to the Observatory

BUG=
==========

to

==========
Surfaced native heap memory allocation information to the Observatory

BUG=
R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c8e275537dd9288a423c3a432d417379a49c6a4a
==========

[bkonyi, 2017-02-01 00:10:03]

Committed patchset #2 (id:20001) manually as
c8e275537dd9288a423c3a432d417379a49c6a4a (presubmit successful).