Linux Aura: Use Aura theme on all windows when 'Use Classic theme' is used

chrome/browser/ui/views/chrome_views_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/chrome_views_delegate.h"
 
 #include <memory>
 
 #include "base/location.h"
 #include "base/logging.h"
@@ skipping 432 matching lines @@
   if (params->context)
     params->context = params->context->GetRootWindow();
   DCHECK(params->parent || params->context || !params->child)
       << "Please provide a parent or context for this widget.";
   if (!params->parent && !params->context)
     params->context = ash::Shell::GetPrimaryRootWindow();
 #elif defined(USE_AURA)
   // While the majority of the time, context wasn't plumbed through due to the
   // existence of a global WindowParentingClient, if this window is toplevel,
   // it's possible that there is no contextual state that we can use.
-  if (params->parent == NULL && params->context == NULL && !params->child) {
-    params->native_widget = new views::DesktopNativeWidgetAura(delegate);
-  } else if (use_non_toplevel_window) {
-    views::NativeWidgetAura* native_widget =
-        new views::NativeWidgetAura(delegate);
-    if (params->parent) {
-      Profile* parent_profile = reinterpret_cast<Profile*>(
-          params->parent->GetNativeWindowProperty(Profile::kProfileKey));
-      native_widget->SetNativeWindowProperty(Profile::kProfileKey,
-                                             parent_profile);
-    }
-    params->native_widget = native_widget;
+  gfx::NativeWindow parent_or_context =
+      params->parent ? params->parent : params->context;
+  void* profile =
+      parent_or_context
+          ? parent_or_context->GetNativeWindowProperty(Profile::kProfileKey)
+          : nullptr;
+  if (!params->parent && !params->context && !params->child &&
+      !use_non_toplevel_window) {
+    views::DesktopNativeWidgetAura* widget =
+        new views::DesktopNativeWidgetAura(delegate);
+    params->native_widget = widget;
+    if (profile)
+      widget->SetNativeWindowProperty(Profile::kProfileKey, nullptr);

[sky, 2017/01/31 17:37:18]

Don't you want profile here? Also, you should be able to call
SetNativeWindowProperty with null, so no conditional.

[Tom (Use chromium acct), 2017/01/31 18:10:29]

Done.  Yes it was broken with nullptr

   } else {
-    params->native_widget = new views::DesktopNativeWidgetAura(delegate);
+    views::NativeWidgetAura* widget = new views::NativeWidgetAura(delegate);
+    params->native_widget = widget;
+    if (profile)
+      widget->SetNativeWindowProperty(Profile::kProfileKey, nullptr);
   }
 #endif
 }
 
 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
 bool ChromeViewsDelegate::WindowManagerProvidesTitleBar(bool maximized) {
   // On Ubuntu Unity, the system always provides a title bar for maximized
   // windows.
   views::LinuxUI* ui = views::LinuxUI::instance();
   return maximized && ui && ui->UnityIsRunning();
@@ skipping 94 matching lines @@
   return ViewsDelegate::GetBubbleDialogMargins();
 }
 
 #if !defined(USE_ASH)
 views::Widget::InitParams::WindowOpacity
 ChromeViewsDelegate::GetOpacityForInitParams(
     const views::Widget::InitParams& params) {
   return views::Widget::InitParams::OPAQUE_WINDOW;
 }
 #endif