Issue 2667633004: Remove class FastUri from analyzer.

Issue 2667633004: Remove class FastUri from analyzer. (Closed)

Created:
3 years, 10 months ago by Paul Berry

Modified:
3 years, 10 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Remove class FastUri from analyzer. After FastUri was introduced, Dart's native Uri implementation was significantly improved (see afbbbb97cfcd86a64d0ba5dcfe1ab758954adaf4) to the point where FastUri no longer provides a significant speed boost. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/62b6e8995a5e4f44a670149ffcff069586fbd956

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -585 lines)			Patch
M	pkg/analyzer/lib/src/context/source.dart	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	pkg/analyzer/lib/src/dart/analysis/file_state.dart	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/bazel.dart	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/gn.dart	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/utilities_dart.dart	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/package_bundle_reader.dart	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/pub_summary.dart	View	3 chunks	+2 lines, -3 lines	0 comments	Download
D	pkg/analyzer/lib/src/util/fast_uri.dart	View	1 chunk	+0 lines, -366 lines	0 comments	Download
M	pkg/analyzer/test/src/dart/analysis/file_state_test.dart	View	5 chunks	+8 lines, -9 lines	0 comments	Download
M	pkg/analyzer/test/src/dart/sdk/patch_test.dart	View	6 chunks	+5 lines, -6 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/package_bundle_reader_test.dart	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/pub_summary_test.dart	View	2 chunks	+1 line, -2 lines	0 comments	Download
D	pkg/analyzer/test/src/util/fast_uri_test.dart	View	1 chunk	+0 lines, -179 lines	0 comments	Download
M	pkg/analyzer/test/src/util/test_all.dart	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

3 years, 10 months ago (2017-01-30 20:05:11 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
62b6e8995a5e4f44a670149ffcff069586fbd956 (presubmit successful).