third_party/WebKit/Source/core/style/ComputedStyle.cpp - Issue 2667543002: Moved nonproperty 'unique' to be generated in ComputedStyleBase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2667543002: Moved nonproperty 'unique' to be generated in ComputedStyleBase. (Closed)

Patch Set: Rebase onto master Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp

diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

index deca619c92323d67c5a079fac53e1d3860d8f849..61aa1d6d27aef52c3e00445ee181f5cc574ee24f 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp

+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

@@ -387,7 +387,7 @@ void ComputedStyle::copyNonInheritedFromCached(const ComputedStyle& other) {

// m_nonInheritedData.m_explicitInheritance

// unique() styles are not cacheable.

- DCHECK(!other.m_nonInheritedData.m_unique);

+ DCHECK(!other.unique());

// styles with non inherited properties that reference variables are not

// cacheable.