Moved nonproperty 'unique' to be generated in ComputedStyleBase.

third_party/WebKit/Source/core/style/ComputedStyle.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 255 matching lines @@
     unsigned m_breakBefore : 4;  // EBreak
     unsigned m_breakAfter : 4;   // EBreak
     unsigned m_breakInside : 2;  // EBreak
 
     unsigned m_styleType : 6;  // PseudoId
     unsigned m_pseudoBits : 8;
     unsigned m_explicitInheritance : 1;  // Explicitly inherits a non-inherited
                                          // property
     unsigned m_variableReference : 1;  // A non-inherited property references a
                                        // variable or @apply is used.
-    unsigned m_unique : 1;             // Style can not be shared.
 
     unsigned m_emptyState : 1;
 
     unsigned m_affectedByFocus : 1;
     unsigned m_affectedByHover : 1;
     unsigned m_affectedByActive : 1;
     unsigned m_affectedByDrag : 1;
 
     // 64 bits
 
@@ skipping 24 matching lines @@
     m_nonInheritedData.m_position = initialPosition();
     m_nonInheritedData.m_tableLayout =
         static_cast<unsigned>(initialTableLayout());
     m_nonInheritedData.m_breakBefore = initialBreakBefore();
     m_nonInheritedData.m_breakAfter = initialBreakAfter();
     m_nonInheritedData.m_breakInside = initialBreakInside();
     m_nonInheritedData.m_styleType = PseudoIdNone;
     m_nonInheritedData.m_pseudoBits = 0;
     m_nonInheritedData.m_explicitInheritance = false;
     m_nonInheritedData.m_variableReference = false;
-    m_nonInheritedData.m_unique = false;
     m_nonInheritedData.m_emptyState = false;
     m_nonInheritedData.m_hasViewportUnits = false;
     m_nonInheritedData.m_affectedByFocus = false;
     m_nonInheritedData.m_affectedByHover = false;
     m_nonInheritedData.m_affectedByActive = false;
     m_nonInheritedData.m_affectedByDrag = false;
     m_nonInheritedData.m_isLink = false;
     m_nonInheritedData.m_hasRemUnits = false;
   }
 
@@ skipping 2279 matching lines @@
   // contexts below are painted.
   // See CSS 2.1, Appendix E (https://www.w3.org/TR/CSS21/zindex.html) for more
   // details.
   bool isStackingContext() const {
     return m_rareNonInheritedData->m_isStackingContext;
   }
   void setIsStackingContext(bool b) {
     SET_VAR(m_rareNonInheritedData, m_isStackingContext, b);
   }
 
-  // A unique style is one that has matches something that makes it impossible
-  // to share.
-  bool unique() const { return m_nonInheritedData.m_unique; }
-  void setUnique() { m_nonInheritedData.m_unique = true; }

[sashab, 2017/02/03 04:53:06]

Maybe just do one prework patch to change setUnique to

setUnique(bool isUnique)

This way its consistent with property fields, which I think is better.

[shend, 2017/02/03 05:11:33]

See the other comment :)

-
   float textAutosizingMultiplier() const {
     return m_styleInheritedData->textAutosizingMultiplier;
   }
   void setTextAutosizingMultiplier(float);
 
   bool selfOrAncestorHasDirAutoAttribute() const {
     return m_rareInheritedData->m_selfOrAncestorHasDirAutoAttribute;
   }
   void setSelfOrAncestorHasDirAutoAttribute(bool v) {
     SET_VAR(m_rareInheritedData, m_selfOrAncestorHasDirAutoAttribute, v);
@@ skipping 1289 matching lines @@
   m_nonInheritedData.m_pseudoBits |= 1 << (pseudo - 1);
 }
 
 inline bool ComputedStyle::hasPseudoElementStyle() const {
   return m_nonInheritedData.m_pseudoBits & ElementPseudoIdMask;
 }
 
 }  // namespace blink
 
 #endif  // ComputedStyle_h