Moved nonproperty 'unique' to be generated in ComputedStyleBase.

third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

 {% from 'macros.tmpl' import license %}
 {{license()}}
 
 #ifndef ComputedStyleBase_h
 #define ComputedStyleBase_h
 
 #include "core/ComputedStyleBaseConstants.h"
 #include "core/CoreExport.h"
 {% for field in fields if field.storage_type_path != None %}
 #include "{{field.storage_type_path}}.h"
@@ skipping 85 matching lines @@
   // Copies the values of any independent inherited properties from the parent
   // style that are marked as inherited by this style.
   void propagateIndependentInheritedProperties(
       const ComputedStyleBase& parentStyle);
 
   // Fields.
   // TODO(sashab): Remove initialFoo() static methods and update callers to
   // use resetFoo(), which can be more efficient.
   {% for field in fields %}
   // {{field.property_name}}
+  {% if field.is_property or field.is_inherited_flag %}

[sashab, 2017/02/03 04:53:06]

Do you need this? Why not have a way to get the default value for nonproperty
fields?

[shend, 2017/02/03 05:11:32]

I was trying to keep the generated code the same as the original, but yeah we
don't need this.

   inline static {{field.storage_type}} {{field.initial_method_name}}() { return {{field.default_value}}; }
+  {% endif %}
   {{field.storage_type}} {{field.getter_method_name}}() const { return static_cast<{{field.storage_type}}>({{field.name}}); }
+  {% if field.is_nonproperty %}
+  void {{field.setter_method_name}}() { {{field.name}} = true; }

[sashab, 2017/02/03 04:53:06]

Ahh, this is kind of annoying! Would be great to keep this template consistent
for all fields.

Can we refactor non-property setters to take a bool? Then the regular setter:
void {{field.setter_method_name}}({{field.storage_type}} v) { {{field.name}} =
static_cast<unsigned>(v); }

Would be like:

void setIsFoo(bool v) { m_isFoo = v; }

Technically non-property fields *should* be able to be set to both true and
false (it's just a regular field), so I think we should allow this functionality
anyway.

[shend, 2017/02/03 05:11:32]

Yeah, so all nonproperty fields I've seen use the setIsFoo() style. I kept it
because I assumed it was like that for a reason (prevent people from setting it
to false or something). I would be hesitant about changing it without knowing
the rationale behind the setIsFoo() style (maybe it's really important). But if
there's no particular reason, then yeah your suggestion is much better.

+  {% else %}
   void {{field.setter_method_name}}({{field.storage_type}} v) { {{field.name}} = static_cast<unsigned>(v); }
+  {% endif %}
   inline void {{field.resetter_method_name}}() { {{field.name}} = {{default_value(field)}}; }
 
   {% endfor %}
  protected:
   // Storage.
   {% for field in fields %}
   unsigned {{field.name}} : {{field.size}}; // {{field.storage_type}}
   {% endfor %}
 };
 
 } // namespace blink
 
 #endif // ComputedStyleBase_h