Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: base/threading/worker_pool_win.cc

Issue 2667513003: Remove some LazyInstance use in base/ (Closed)
Patch Set: no message_window Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/threading/worker_pool_win.cc
diff --git a/base/threading/worker_pool_win.cc b/base/threading/worker_pool_win.cc
index d638c0f1e42e8532c1bf2ca06d82294631f25192..1b16bdccdbf3410525465ad4303dbd3cbd33b6b0 100644
--- a/base/threading/worker_pool_win.cc
+++ b/base/threading/worker_pool_win.cc
@@ -16,21 +16,23 @@ namespace base {
namespace {
-base::LazyInstance<ThreadLocalBoolean>::Leaky
- g_worker_pool_running_on_this_thread = LAZY_INSTANCE_INITIALIZER;
+ThreadLocalBoolean* GetWorkerPoolRunningOnThisThread() {
+ static auto thread_local_boolean = new ThreadLocalBoolean();
+ return thread_local_boolean;
+}
DWORD CALLBACK WorkItemCallback(void* param) {
PendingTask* pending_task = static_cast<PendingTask*>(param);
TRACE_TASK_EXECUTION("WorkerThread::ThreadMain::Run", *pending_task);
- g_worker_pool_running_on_this_thread.Get().Set(true);
+ GetWorkerPoolRunningOnThisThread()->Set(true);
tracked_objects::TaskStopwatch stopwatch;
stopwatch.Start();
std::move(pending_task->task).Run();
stopwatch.Stop();
- g_worker_pool_running_on_this_thread.Get().Set(false);
+ GetWorkerPoolRunningOnThisThread()->Set(false);
tracked_objects::ThreadData::TallyRunOnWorkerThreadIfTracking(
pending_task->birth_tally, pending_task->time_posted, stopwatch);
@@ -65,7 +67,7 @@ bool WorkerPool::PostTask(const tracked_objects::Location& from_here,
// static
bool WorkerPool::RunsTasksOnCurrentThread() {
- return g_worker_pool_running_on_this_thread.Get().Get();
+ return GetWorkerPoolRunningOnThisThread()->Get();
}
} // namespace base

Powered by Google App Engine
This is Rietveld 408576698