Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js

Issue 2667513002: DevTools: Missing parenthesis on url in NetworkLog (Closed) Base URL: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/devtools@master
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 127
128 var type = SDK.NetworkRequest.InitiatorType.Other; 128 var type = SDK.NetworkRequest.InitiatorType.Other;
129 var url = ''; 129 var url = '';
130 var lineNumber = -Infinity; 130 var lineNumber = -Infinity;
131 var columnNumber = -Infinity; 131 var columnNumber = -Infinity;
132 var scriptId = null; 132 var scriptId = null;
133 var initiator = request.initiator(); 133 var initiator = request.initiator();
134 134
135 if (request.redirectSource) { 135 if (request.redirectSource) {
136 type = SDK.NetworkRequest.InitiatorType.Redirect; 136 type = SDK.NetworkRequest.InitiatorType.Redirect;
137 url = request.redirectSource.url; 137 url = request.redirectSource.url();
138 } else if (initiator) { 138 } else if (initiator) {
139 if (initiator.type === Protocol.Network.InitiatorType.Parser) { 139 if (initiator.type === Protocol.Network.InitiatorType.Parser) {
140 type = SDK.NetworkRequest.InitiatorType.Parser; 140 type = SDK.NetworkRequest.InitiatorType.Parser;
141 url = initiator.url ? initiator.url : url; 141 url = initiator.url ? initiator.url : url;
142 lineNumber = initiator.lineNumber ? initiator.lineNumber : lineNumber; 142 lineNumber = initiator.lineNumber ? initiator.lineNumber : lineNumber;
143 } else if (initiator.type === Protocol.Network.InitiatorType.Script) { 143 } else if (initiator.type === Protocol.Network.InitiatorType.Script) {
144 for (var stack = initiator.stack; stack; stack = stack.parent) { 144 for (var stack = initiator.stack; stack; stack = stack.parent) {
145 var topFrame = stack.callFrames.length ? stack.callFrames[0] : null; 145 var topFrame = stack.callFrames.length ? stack.callFrames[0] : null;
146 if (!topFrame) 146 if (!topFrame)
147 continue; 147 continue;
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 327
328 /** @typedef {!{initiators: !Set<!SDK.NetworkRequest>, initiated: !Set<!SDK.Netw orkRequest>}} */ 328 /** @typedef {!{initiators: !Set<!SDK.NetworkRequest>, initiated: !Set<!SDK.Netw orkRequest>}} */
329 SDK.NetworkLog.InitiatorGraph; 329 SDK.NetworkLog.InitiatorGraph;
330 330
331 /** @typedef {!{type: !SDK.NetworkRequest.InitiatorType, url: string, lineNumber : number, columnNumber: number, scriptId: ?string}} */ 331 /** @typedef {!{type: !SDK.NetworkRequest.InitiatorType, url: string, lineNumber : number, columnNumber: number, scriptId: ?string}} */
332 SDK.NetworkLog._InitiatorInfo; 332 SDK.NetworkLog._InitiatorInfo;
333 333
334 SDK.NetworkLog._initiatorDataSymbol = Symbol('InitiatorData'); 334 SDK.NetworkLog._initiatorDataSymbol = Symbol('InitiatorData');
335 SDK.NetworkLog._pageLoadForRequestSymbol = Symbol('PageLoadForRequest'); 335 SDK.NetworkLog._pageLoadForRequestSymbol = Symbol('PageLoadForRequest');
336 SDK.NetworkLog._logSymbol = Symbol('NetworkLog'); 336 SDK.NetworkLog._logSymbol = Symbol('NetworkLog');
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698