Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2667473003: Move Entity and Local to entities.dart (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move Entity and Local to entities.dart - and use entities in Name, MapLiteralUse and ListLiteralUse. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/4927afc21f6b9e718f15956a5ca987dd13b3f5eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -99 lines) Patch
M pkg/compiler/lib/src/closure.dart View 4 chunks +10 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 3 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +7 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/constants/values.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/core_types.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 4 chunks +3 lines, -33 lines 0 comments Download
M pkg/compiler/lib/src/elements/entities.dart View 2 chunks +38 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/names.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/locals_handler.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/type_system.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 3 chunks +6 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/native_data.dart View 1 chunk +2 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/constant_ordering.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_builder.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/element_adapter.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/impact_serialization.dart View 4 chunks +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/graph_builder.dart View 1 chunk +2 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 4 chunks +8 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/type_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/types/masks.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/feature.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/universe/use.dart View 2 chunks +2 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 10 months ago (2017-01-30 14:08:19 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-01-30 18:56:26 UTC) #3
Johnni Winther
3 years, 10 months ago (2017-01-31 09:02:26 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
4927afc21f6b9e718f15956a5ca987dd13b3f5eb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698