Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: chrome/utility/media_galleries/media_metadata_parser.h

Issue 2667443002: Convert utility process ParseMediaMetadata blob reading IPC to mojo (Closed)
Patch Set: Remove the damn helper: call ReleaseProcessIfNeeded directly. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/utility/media_galleries/media_metadata_parser.h
diff --git a/chrome/utility/media_galleries/media_metadata_parser.h b/chrome/utility/media_galleries/media_metadata_parser.h
index 1e7720b6a763ae8bbff810cdf67a2b8292abe2b7..bb914f2ae1e075ca0224613e581585c15059c253 100644
--- a/chrome/utility/media_galleries/media_metadata_parser.h
+++ b/chrome/utility/media_galleries/media_metadata_parser.h
@@ -36,9 +36,8 @@ class MediaMetadataParser {
const std::vector<AttachedImage>& attached_images)>
MetadataCallback;
- // Does not take ownership of |source|. Caller is responsible for ensuring
- // that |source| outlives this object.
- MediaMetadataParser(media::DataSource* source, const std::string& mime_type,
+ MediaMetadataParser(std::unique_ptr<media::DataSource> source,
+ const std::string& mime_type,
bool get_attached_images);
~MediaMetadataParser();
@@ -48,7 +47,7 @@ class MediaMetadataParser {
private:
// Only accessed on |media_thread_| from this class.
- media::DataSource* const source_;
+ std::unique_ptr<media::DataSource> source_;
const std::string mime_type_;

Powered by Google App Engine
This is Rietveld 408576698