third_party/WebKit/LayoutTests/fast/dom/dataset-gc.html - Issue 2667393002: Stop using script-tests in fast/dom/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/dataset-gc.html

Issue 2667393002: Stop using script-tests in fast/dom/. (Closed)

Patch Set: . Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/LayoutTests/fast/dom/dataset-gc.html

diff --git a/third_party/WebKit/LayoutTests/fast/dom/dataset-gc.html b/third_party/WebKit/LayoutTests/fast/dom/dataset-gc.html

index 9729ca9ef98959b1eacd2c8bf7f5427c691eaa49..9f55e6dc70ebcb4b849c7acf4f1a2bedb2ab0b0b 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/dataset-gc.html

+++ b/third_party/WebKit/LayoutTests/fast/dom/dataset-gc.html

@@ -4,6 +4,35 @@

</head>

<body>

-<script src="script-tests/dataset-gc.js"></script>

+<script>

+description("This tests that custom properties on element.dataset persist GC.");

+function gc()

+ if (window.GCController)

+ return GCController.collect();

+ for (var i = 0; i < 10000; i++) {

+ var s = new String("");

+ }

+var d = document.createElement("div");

+var dataset = d.dataset;

+// Add a property to our prototype. It will be hidden by the corresponding data- attribute.

+dataset.__proto__.customProperty = 1;

+dataset.customProperty = 1; // Now set a property on ourselves.

+shouldBe("d.getAttribute('data-custom-property')", "'1'");

+shouldBe("d.dataset.customProperty", "'1'");

+dataset = null;

+gc();

+// Test that the custom property persisted the GC.

+shouldBe("d.dataset.customProperty", "'1'");

+</script>

</body>

</html>