Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/Geolocation/timeout-clear-watch.html

Issue 2667393002: Stop using script-tests in fast/dom/. (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/Geolocation/timeout-clear-watch.html
diff --git a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/timeout-clear-watch.html b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/timeout-clear-watch.html
index 6b3d6e3b89e42cb4f0bec85685b3f82b76e0559a..fe0d97f3edfc360e59b62917d417d3d02f55abf1 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/timeout-clear-watch.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/timeout-clear-watch.html
@@ -6,6 +6,29 @@
<script src="resources/geolocation-mock.js"></script>
</head>
<body>
-<script src="script-tests/timeout-clear-watch.js"></script>
+<script>
+description("Tests that when a watch times out and is cleared from the error callback, there is no crash. This a regression test for https://bugs.webkit.org/show_bug.cgi?id=32111.");
+
+var error;
+
+geolocationServiceMock.then(mock => {
+ mock.setGeolocationPosition(51.478, -0.166, 100.0);
+
+ var watchId = navigator.geolocation.watchPosition(function() {
+ testFailed('Success callback invoked unexpectedly');
+ finishJSTest();
+ }, function(e) {
+ error = e;
+ shouldBe('error.code', 'error.TIMEOUT');
+ shouldBe('error.message', '"Timeout expired"');
+ navigator.geolocation.clearWatch(watchId);
+ window.setTimeout(finishJSTest, 0);
+ }, {
+ timeout: 0
+ });
+});
+
+window.jsTestIsAsync = true;
+</script>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698