Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/Geolocation/permission-denied-already-clear-watch.html

Issue 2667393002: Stop using script-tests in fast/dom/. (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/Geolocation/permission-denied-already-clear-watch.html
diff --git a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/permission-denied-already-clear-watch.html b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/permission-denied-already-clear-watch.html
index 228415e330ae69d1fa1e8bd6b339f1012d87699b..a7f6bda5ca6dcefbc02c8f195765b88c5f7901b7 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/permission-denied-already-clear-watch.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/permission-denied-already-clear-watch.html
@@ -6,6 +6,45 @@
<script src="resources/geolocation-mock.js"></script>
</head>
<body>
-<script src="script-tests/permission-denied-already-clear-watch.js"></script>
+<script>
+description("Tests that when Geolocation permission has been denied prior to a call to watchPosition, and the watch is cleared in the error callback, there is no crash. This a regression test for https://bugs.webkit.org/show_bug.cgi?id=32111.");
+
+var error;
+
+geolocationServiceMock.then(mock => {
+
+ // Prime the Geolocation instance by denying permission.
+ mock.setGeolocationPermission(false);
+ mock.setGeolocationPosition(51.478, -0.166, 100);
+
+ navigator.geolocation.getCurrentPosition(function(p) {
+ testFailed('Success callback invoked unexpectedly');
+ finishJSTest();
+ }, function(e) {
+ error = e;
+ shouldBe('error.code', 'error.PERMISSION_DENIED');
+ shouldBe('error.message', '"User denied Geolocation"');
+ debug('');
+ continueTest();
+ });
+
+ function continueTest()
+ {
+ // Make another request, with permission already denied.
+ var watchId = navigator.geolocation.watchPosition(function(p) {
+ testFailed('Success callback invoked unexpectedly');
+ finishJSTest();
+ }, function(e) {
+ error = e;
+ shouldBe('error.code', 'error.PERMISSION_DENIED');
+ shouldBe('error.message', '"User denied Geolocation"');
+ navigator.geolocation.clearWatch(watchId);
+ window.setTimeout(finishJSTest, 0);
+ });
+ }
+});
+
+window.jsTestIsAsync = true;
+</script>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698