Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/Geolocation/disconnected-frame-already.html

Issue 2667393002: Stop using script-tests in fast/dom/. (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/Geolocation/disconnected-frame-already.html
diff --git a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/disconnected-frame-already.html b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/disconnected-frame-already.html
index f3c5a8099d8a8cae0dc0424c8bfc83cef5328e9f..a4d7e3dc6a49e70a0a76a96d90e374fb1df584f1 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/disconnected-frame-already.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/disconnected-frame-already.html
@@ -6,6 +6,41 @@
<script src="resources/geolocation-mock.js"></script>
</head>
<body>
-<script src="script-tests/disconnected-frame-already.js"></script>
+<script>
+description("Tests that when a request is made on a Geolocation object after its frame has been disconnected, no callbacks are made and no crash occurs.");
+
+var iframe = document.createElement('iframe');
+
+geolocationServiceMock.then(mock => {
+ mock.setGeolocationPermission(true);
+ mock.setGeolocationPosition(51.478, -0.166, 100);
+
+ iframe.src = 'resources/disconnected-frame-already-inner1.html';
+ document.body.appendChild(iframe);
+});
+
+function onFirstIframeLoaded() {
+ iframeGeolocation = iframe.contentWindow.navigator.geolocation;
+ iframe.src = 'resources/disconnected-frame-already-inner2.html';
+}
+
+function onSecondIframeLoaded() {
+ iframeGeolocation.getCurrentPosition(function () {
+ testFailed('Success callback invoked unexpectedly');
+ finishJSTest();
+ }, function(e) {
+ testFailed('Error callback invoked unexpectedly');
+ finishJSTest();
+ });
+ setTimeout(finishTest, 1000);
+}
+
+function finishTest() {
+ debug('Method called on Geolocation object with disconnected Frame.');
+ finishJSTest();
+}
+
+window.jsTestIsAsync = true;
+</script>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698