third_party/WebKit/LayoutTests/fast/dom/Geolocation/clear-watch-invalid-id-crash.html - Issue 2667393002: Stop using script-tests in fast/dom/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/Geolocation/clear-watch-invalid-id-crash.html

Issue 2667393002: Stop using script-tests in fast/dom/. (Closed)

Patch Set: . Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/Geolocation/callback-to-remote-context2.html ('k') | third_party/WebKit/LayoutTests/fast/dom/Geolocation/delayed-permission-allowed.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/Geolocation/clear-watch-invalid-id-crash.html

diff --git a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/clear-watch-invalid-id-crash.html b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/clear-watch-invalid-id-crash.html

index e2188726801bfafe007ab32bb857fe7937181a6a..da513cdc7bba1aef1924718c88ed22705175da81 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/clear-watch-invalid-id-crash.html

+++ b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/clear-watch-invalid-id-crash.html

@@ -6,6 +6,24 @@

</head>

<body>

-<script src="script-tests/clear-watch-invalid-id-crash.js"></script>

+<script>

+description("Tests for a crash when clearWatch() is called with a zero ID.<br><br>We call clearWatch() with a request in progress then navigate the page. This accesses the watchers map during cleanup and triggers the crash. This page should not be visible when the test completes.");

+if (!window.testRunner)

+ debug('This test can not run without testRunner');

+document.body.onload = function() {

+ geolocationServiceMock.then(mock => {

+ mock.setGeolocationPermission(true);

+ mock.setGeolocationPosition(51.478, -0.166, 100);

+ navigator.geolocation.watchPosition(function() {});

+ navigator.geolocation.clearWatch(0);

+ location = "data:text/html,TEST COMPLETE<script>if(window.testRunner) testRunner.notifyDone();</" + "script>";

+ });

+window.jsTestIsAsync = true;

+</script>

</body>

</html>