third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp - Issue 2667373002: Ensure PaintArtifactCompositor assigns a scroll tree index to all cc layers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

Issue 2667373002: Ensure PaintArtifactCompositor assigns a scroll tree index to all cc layers (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayer.cpp ('k') | third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp » ('j') | third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

index d5df483ed1f9c958fec42f2826be75a8333516c3..636b45ce1e44e66b4a337234707fe4286f4a7099 100644

--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

@@ -723,10 +723,8 @@ void PaintArtifactCompositor::update(

layer->SetTransformTreeIndex(transformId);

layer->SetClipTreeIndex(clipId);

layer->SetEffectTreeIndex(effectId);

- if (const auto* scrollNode = transform->scrollNode()) {

- layer->SetScrollTreeIndex(

- propertyTreeManager.ensureCompositorScrollNode(scrollNode));

- }

+ layer->SetScrollTreeIndex(propertyTreeManager.ensureCompositorScrollNode(

+ transform->findEnclosingScrollNode()));

layer->SetShouldCheckBackfaceVisibility(pendingLayer.backfaceHidden);