components/password_manager/core/browser/form_fetcher_impl.cc - Issue 2667363003: Enable moving of credentials in HttpPasswordMigrator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/form_fetcher_impl.cc

Issue 2667363003: Enable moving of credentials in HttpPasswordMigrator (Closed)

Patch Set: Moved test methods out of class Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/form_fetcher_impl.cc

diff --git a/components/password_manager/core/browser/form_fetcher_impl.cc b/components/password_manager/core/browser/form_fetcher_impl.cc

index e4f8ed6f2a4ac0ffec9f144a51763607de42ec28..6bff00d8fc6926e333c0316ff59925cc77ad3387 100644

--- a/components/password_manager/core/browser/form_fetcher_impl.cc

+++ b/components/password_manager/core/browser/form_fetcher_impl.cc

@@ -111,7 +111,8 @@ void FormFetcherImpl::OnGetPasswordStoreResults(

if (should_migrate_http_passwords_ && results.empty() &&

form_digest_.origin.SchemeIs(url::kHttpsScheme)) {

http_migrator_ = base::MakeUnique<HttpPasswordMigrator>(

- form_digest_.origin, client_->GetPasswordStore(), this);

+ form_digest_.origin, HttpPasswordMigrator::MigrationMode::COPY,

+ client_->GetPasswordStore(), this);

return;

}