components/password_manager/core/browser/credential_manager_pending_request_task.cc - Issue 2667363003: Enable moving of credentials in HttpPasswordMigrator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/credential_manager_pending_request_task.cc

Issue 2667363003: Enable moving of credentials in HttpPasswordMigrator (Closed)

Patch Set: Comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/password_manager/core/browser/form_fetcher_impl.cc » ('j') | components/password_manager/core/browser/http_password_migrator_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/credential_manager_pending_request_task.cc

diff --git a/components/password_manager/core/browser/credential_manager_pending_request_task.cc b/components/password_manager/core/browser/credential_manager_pending_request_task.cc

index fc1061fa758b7cd9d3e6dccfd30effb8a017caf9..63c79bb0a5c1991f5cd2c98e7263994ed10f0f59 100644

--- a/components/password_manager/core/browser/credential_manager_pending_request_task.cc

+++ b/components/password_manager/core/browser/credential_manager_pending_request_task.cc

@@ -134,7 +134,8 @@ void CredentialManagerPendingRequestTask::OnGetPasswordStoreResults(

if (results.empty()) {

// Try to migrate the HTTP passwords and process them later.

http_migrator_ = base::MakeUnique<HttpPasswordMigrator>(

- origin_, delegate_->client()->GetPasswordStore(), this);

+ origin_, HttpPasswordMigrator::MigrationMode::COPY,

+ delegate_->client()->GetPasswordStore(), this);

return;

}

ProcessForms(std::move(results));