Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1498)

Unified Diff: milo/appengine/swarming/html.go

Issue 2667363002: milo: Add a build info Swarming implementation. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/appengine/swarming/buildinfo_test.go ('k') | milo/appengine/swarming/html_data.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/swarming/html.go
diff --git a/milo/appengine/swarming/html.go b/milo/appengine/swarming/html.go
index 5fb3bea18f00ef2a13ea75e620131be35a50dbe1..2b1b3e76de5843c1ad364e4b21aa85b087e2b8b9 100644
--- a/milo/appengine/swarming/html.go
+++ b/milo/appengine/swarming/html.go
@@ -8,11 +8,12 @@ import (
"net/http"
"os"
- "google.golang.org/api/googleapi"
-
"github.com/julienschmidt/httprouter"
"golang.org/x/net/context"
+ "google.golang.org/api/googleapi"
+ "google.golang.org/grpc/codes"
+ "github.com/luci/luci-go/grpc/grpcutil"
"github.com/luci/luci-go/milo/appengine/settings"
"github.com/luci/luci-go/milo/common/miloerror"
"github.com/luci/luci-go/server/templates"
@@ -31,6 +32,8 @@ func getSwarmingService(c context.Context, r *http.Request) (swarmingService, er
server = defaultSwarmingServer
case "dev":
server = defaultSwarmingDevServer
+ default:
+ return nil, grpcutil.Errf(codes.InvalidArgument, "invalid swarming server")
}
return newProdService(c, server)
}
« no previous file with comments | « milo/appengine/swarming/buildinfo_test.go ('k') | milo/appengine/swarming/html_data.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698