Skip the type test for expressions which have already evaluated to true or false.

Skip the type test for expressions which have already evaluated to true or false.

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/1660cab84d331f54ea59f64f8fd08dac38e9422b

[Cutch, 2017-02-02 18:54:27]

Description was changed from

==========
Skip the type test for expressions which have already evaluated to true or
false.

BUG=
==========

to

==========
Skip the type test for expressions which have already evaluated to true or
false.

BUG=
==========

[Cutch, 2017-02-02 18:54:28]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2017-02-02 19:02:05]

lgtm

https://codereview.chromium.org/2667353003/diff/1/runtime/lib/errors_patch.dart
File runtime/lib/errors_patch.dart (right):

https://codereview.chromium.org/2667353003/diff/1/runtime/lib/errors_patch.da...
runtime/lib/errors_patch.dart:39: if (condition is Function) {
It might be worth adding

if (condition is _Closure) {
  return condition();
}

[Cutch, 2017-02-02 19:57:49]

https://codereview.chromium.org/2667353003/diff/1/runtime/lib/errors_patch.dart
File runtime/lib/errors_patch.dart (right):

https://codereview.chromium.org/2667353003/diff/1/runtime/lib/errors_patch.da...
runtime/lib/errors_patch.dart:39: if (condition is Function) {
On 2017/02/02 19:02:05, rmacnak wrote:
> It might be worth adding
> 
> if (condition is _Closure) {
>   return condition();
> }

Done.

[Cutch, 2017-02-02 19:58:35]

Description was changed from

==========
Skip the type test for expressions which have already evaluated to true or
false.

BUG=
==========

to

==========
Skip the type test for expressions which have already evaluated to true or
false.

BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1660cab84d331f54ea59f64f8fd08dac38e9422b
==========

[Cutch, 2017-02-02 19:58:36]

Committed patchset #1 (id:1) manually as
1660cab84d331f54ea59f64f8fd08dac38e9422b (presubmit successful).