pkg/analyzer/lib/src/generated/type_system.dart - Issue 2667343005: Infer Null for return type of functions with empty returns.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/type_system.dart

Issue 2667343005: Infer Null for return type of functions with empty returns. (Closed)

Patch Set: Address comments, fix 28630, ddc expectations Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/generated/type_system.dart

diff --git a/pkg/analyzer/lib/src/generated/type_system.dart b/pkg/analyzer/lib/src/generated/type_system.dart

index bcf8ad566db77cad173eeaf664aefd8ce4d7a479..1e1d1824caf386948df9cb9b1832c51cb8801a16 100644

--- a/pkg/analyzer/lib/src/generated/type_system.dart

+++ b/pkg/analyzer/lib/src/generated/type_system.dart

@@ -1554,7 +1554,6 @@ class _StrongInferenceTypeSystem extends StrongTypeSystemImpl {

lowerBound = bound.upper;

upperBound = bound.lower;

}

inferredTypes[i] =

variance.passedIn && !upperBound.isDynamic || lowerBound.isBottom

? upperBound