Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Side by Side Diff: components/discardable_memory/service/discardable_shared_memory_manager.cc

Issue 2667343004: Move purging memory from OnMemoryStateChange() to OnPurgeMemory() in discardable_memory (Closed)
Patch Set: comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/discardable_memory/service/discardable_shared_memory_manager.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/discardable_memory/service/discardable_shared_memory_manage r.h" 5 #include "components/discardable_memory/service/discardable_shared_memory_manage r.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/atomic_sequence_num.h" 10 #include "base/atomic_sequence_num.h"
(...skipping 387 matching lines...) Expand 10 before | Expand all | Expand 10 after
398 } 398 }
399 399
400 size_t DiscardableSharedMemoryManager::GetBytesAllocated() { 400 size_t DiscardableSharedMemoryManager::GetBytesAllocated() {
401 base::AutoLock lock(lock_); 401 base::AutoLock lock(lock_);
402 402
403 return bytes_allocated_; 403 return bytes_allocated_;
404 } 404 }
405 405
406 void DiscardableSharedMemoryManager::OnMemoryStateChange( 406 void DiscardableSharedMemoryManager::OnMemoryStateChange(
407 base::MemoryState state) { 407 base::MemoryState state) {
408 // Don't use SetMemoryLimit() as it frees up existing allocations.
409 // OnPurgeMemory() is called to actually free up memory.
410 base::AutoLock lock(lock_);
408 switch (state) { 411 switch (state) {
409 case base::MemoryState::NORMAL: 412 case base::MemoryState::NORMAL:
410 SetMemoryLimit(default_memory_limit_); 413 memory_limit_ = default_memory_limit_;
411 break; 414 break;
412 case base::MemoryState::THROTTLED: 415 case base::MemoryState::THROTTLED:
413 SetMemoryLimit(0); 416 memory_limit_ = 0;
414 break; 417 break;
415 case base::MemoryState::SUSPENDED: 418 case base::MemoryState::SUSPENDED:
416 // Note that SUSPENDED never occurs in the main browser process so far. 419 // Note that SUSPENDED never occurs in the main browser process so far.
417 // Fall through. 420 // Fall through.
418 case base::MemoryState::UNKNOWN: 421 case base::MemoryState::UNKNOWN:
419 NOTREACHED(); 422 NOTREACHED();
420 break; 423 break;
421 } 424 }
422 } 425 }
423 426
427 void DiscardableSharedMemoryManager::OnPurgeMemory() {
428 base::AutoLock lock(lock_);
429 ReduceMemoryUsageUntilWithinLimit(0);
430 }
431
424 void DiscardableSharedMemoryManager::AllocateLockedDiscardableSharedMemory( 432 void DiscardableSharedMemoryManager::AllocateLockedDiscardableSharedMemory(
425 int client_id, 433 int client_id,
426 size_t size, 434 size_t size,
427 int32_t id, 435 int32_t id,
428 base::SharedMemoryHandle* shared_memory_handle) { 436 base::SharedMemoryHandle* shared_memory_handle) {
429 base::AutoLock lock(lock_); 437 base::AutoLock lock(lock_);
430 438
431 // Make sure |id| is not already in use. 439 // Make sure |id| is not already in use.
432 MemorySegmentMap& client_segments = clients_[client_id]; 440 MemorySegmentMap& client_segments = clients_[client_id];
433 if (client_segments.find(id) != client_segments.end()) { 441 if (client_segments.find(id) != client_segments.end()) {
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
617 return; 625 return;
618 626
619 enforce_memory_policy_pending_ = true; 627 enforce_memory_policy_pending_ = true;
620 DCHECK(enforce_memory_policy_task_runner_); 628 DCHECK(enforce_memory_policy_task_runner_);
621 enforce_memory_policy_task_runner_->PostDelayedTask( 629 enforce_memory_policy_task_runner_->PostDelayedTask(
622 FROM_HERE, enforce_memory_policy_callback_, 630 FROM_HERE, enforce_memory_policy_callback_,
623 base::TimeDelta::FromMilliseconds(kEnforceMemoryPolicyDelayMs)); 631 base::TimeDelta::FromMilliseconds(kEnforceMemoryPolicyDelayMs));
624 } 632 }
625 633
626 } // namespace discardable_memory 634 } // namespace discardable_memory
OLDNEW
« no previous file with comments | « components/discardable_memory/service/discardable_shared_memory_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698