Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: net/base/sdch_manager.cc

Issue 2667293003: [OBSOLETE][memory-infra] Whitelist net dump providers in field trials (Closed)
Patch Set: fix comment. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/sdch_manager.cc
diff --git a/net/base/sdch_manager.cc b/net/base/sdch_manager.cc
index d577db8436c1c682fdcc0595febc39a360dd3167..038aada1df7cd84e2e29ed9a7b45a55d56bb8e1d 100644
--- a/net/base/sdch_manager.cc
+++ b/net/base/sdch_manager.cc
@@ -350,11 +350,15 @@ void SdchManager::DumpMemoryStats(
base::trace_event::MemoryAllocatorDump::kUnitsObjects,
total_count);
}
+
// Create an empty row under parent's dump so size can be attributed correctly
- // if |this| is shared between URLRequestContexts.
- base::trace_event::MemoryAllocatorDump* empty_row_dump =
- pmd->CreateAllocatorDump(parent_dump_absolute_name + "/sdch_manager");
- pmd->AddOwnershipEdge(empty_row_dump->guid(), dump->guid());
+ // if |this| is shared between URLRequestContexts. It is not required if
+ // parent details are not reported.
+ if (!parent_dump_absolute_name.empty()) {
+ base::trace_event::MemoryAllocatorDump* empty_row_dump =
+ pmd->CreateAllocatorDump(parent_dump_absolute_name + "/sdch_manager");
+ pmd->AddOwnershipEdge(empty_row_dump->guid(), dump->guid());
+ }
}
SdchProblemCode SdchManager::AddSdchDictionary(

Powered by Google App Engine
This is Rietveld 408576698