[OBSOLETE][memory-infra] Whitelist net dump providers in field trials

net/url_request/url_request_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_context.h"
 
 #include "base/compiler_specific.h"
 #include "base/debug/alias.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_util.h"
@@ skipping 109 matching lines @@
     CHECK(false) << "Leaked " << num_requests << " URLRequest(s). First URL: "
                  << request->url().spec().c_str() << ".";
   }
 }
 
 bool URLRequestContext::OnMemoryDump(
     const base::trace_event::MemoryDumpArgs& args,
     base::trace_event::ProcessMemoryDump* pmd) {
   if (name_.empty())
     name_ = "unknown";
-  base::trace_event::MemoryAllocatorDump* dump = pmd->CreateAllocatorDump(
-      base::StringPrintf("net/url_request_context/%s_%p", name_.c_str(), this));
-  dump->AddScalar(base::trace_event::MemoryAllocatorDump::kNameObjectCount,
-                  base::trace_event::MemoryAllocatorDump::kUnitsObjects,
-                  url_requests_->size());
+
+  SSLClientSocketImpl::DumpSSLClientSessionMemoryStats(pmd);
+
+  // The details about the url request context name are not added in BACKGROUND
+  // mode dumps.
+  std::string dump_name;
+  if (args.level_of_detail !=
+      base::trace_event::MemoryDumpLevelOfDetail::BACKGROUND) {
+    dump_name = base::StringPrintf("net/url_request_context/%s_%p",

[Primiano Tucci (use gerrit), 2017/02/03 03:18:50]

don't you have to do this outside of the if?
otherwise in background mode the DumpMemoryStats calls below will pass an empty
dump_name

[ssid, 2017/02/03 03:27:56]

I am intentionally passing empty dump name here so that the
session::DumpMemoryStats will not add a sub-allocation edge to the parent. Since
we do not attribute the memory to url_request_context anyway, there is no reason
to create these empty dumps in background mode. All we need to see in slow
reports is how much memory http_network_session is using. So, removing these
dumps for now.
I think Helen said she will add these back later in some other CL where she adds
children to these objects.

+                                   name_.c_str(), this);
+    base::trace_event::MemoryAllocatorDump* dump =
+        pmd->CreateAllocatorDump(dump_name);
+    dump->AddScalar(base::trace_event::MemoryAllocatorDump::kNameObjectCount,
+                    base::trace_event::MemoryAllocatorDump::kUnitsObjects,
+                    url_requests_->size());
+  }
   HttpTransactionFactory* transaction_factory = http_transaction_factory();
   if (transaction_factory) {
     HttpNetworkSession* network_session = transaction_factory->GetSession();
     if (network_session)
-      network_session->DumpMemoryStats(pmd, dump->absolute_name());
+      network_session->DumpMemoryStats(pmd, dump_name);
   }
-  SSLClientSocketImpl::DumpSSLClientSessionMemoryStats(pmd);

[Primiano Tucci (use gerrit), 2017/02/03 03:18:50]

just checking, is this removal intended or just accidental?

[ssid, 2017/02/03 03:27:56]

I moved it up since it is a static function call.
Line 131 in right side.

   if (sdch_manager_)
-    sdch_manager_->DumpMemoryStats(pmd, dump->absolute_name());
+    sdch_manager_->DumpMemoryStats(pmd, dump_name);
   return true;
 }
 
 }  // namespace net