Chromium Code Reviews| Index: ash/wm/gestures/overview_gesture_handler.h |
| diff --git a/ash/wm/gestures/overview_gesture_handler.h b/ash/wm/gestures/overview_gesture_handler.h |
| index af1ba739ebc2a45379b672ae166cefed286ba54d..910dfe4a0dba5a1dd1870227246104632d7208fd 100644 |
| --- a/ash/wm/gestures/overview_gesture_handler.h |
| +++ b/ash/wm/gestures/overview_gesture_handler.h |
| @@ -5,6 +5,7 @@ |
| #ifndef ASH_WM_GESTURES_OVERVIEW_GESTURE_HANDLER_H_ |
| #define ASH_WM_GESTURES_OVERVIEW_GESTURE_HANDLER_H_ |
| +#include "ash/ash_export.h" |
| #include "base/macros.h" |
| namespace ui { |
| @@ -14,7 +15,7 @@ class ScrollEvent; |
| namespace ash { |
| // This handles 3-finger touchpad scroll events to enter/exit overview mode. |
| -class OverviewGestureHandler { |
| +class ASH_EXPORT OverviewGestureHandler { |
| public: |
| OverviewGestureHandler(); |
| virtual ~OverviewGestureHandler(); |
| @@ -24,10 +25,21 @@ class OverviewGestureHandler { |
| bool ProcessScrollEvent(const ui::ScrollEvent& event); |
| private: |
| - // The total distance scrolled with three fingers. |
| + friend class OverviewGestureHandlerTest; |
| + |
| + // The total distance scrolled with 2 or three fingers up to the point when |
| + // an action is triggered. When the action (enter / exit overview mode or move |
| + // selection in overview) is triggered those values are reset to zero. |
| float scroll_x_; |
| float scroll_y_; |
| + // The threshold before engaging overview with a touchpad three-finger scroll. |
| + static float vertical_threshold_pixels_; |
|
tdanderson
2017/02/08 23:14:19
I'm not sure why you have made these members stati
varkha
2017/02/09 21:54:42
I feel that initialization in cc and outside of ct
|
| + |
| + // The threshold before moving selector horizontally when using a touchpad |
| + // two or three-finger scroll. |
| + static float horizontal_threshold_pixels_; |
| + |
| DISALLOW_COPY_AND_ASSIGN(OverviewGestureHandler); |
| }; |