[ash-md] Adds support for gesture to move selection in overview mode

ash/wm/gestures/overview_gesture_handler_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/wm/overview/window_selector_controller.h"
 #include "ash/common/wm_shell.h"
 #include "ash/root_window_controller.h"
 #include "ash/shell.h"
 #include "ash/test/ash_test_base.h"
+#include "ash/wm/window_util.h"
 #include "ui/aura/test/test_window_delegate.h"
 #include "ui/aura/test/test_windows.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_event_dispatcher.h"
 #include "ui/events/test/event_generator.h"
 #include "ui/views/widget/widget.h"
 
 namespace ash {
 
 class OverviewGestureHandlerTest : public test::AshTestBase {
@@ skipping 36 matching lines @@
   generator.ScrollSequence(gfx::Point(), base::TimeDelta::FromMilliseconds(5),
                            0, 500, 100, 3);
   EXPECT_FALSE(IsSelecting());
 
   // Swiping down again does nothing.
   generator.ScrollSequence(gfx::Point(), base::TimeDelta::FromMilliseconds(5),
                            0, 500, 100, 3);
   EXPECT_FALSE(IsSelecting());
 }
 
+// Tests a swipe up with three fingers to enter overview and a swipe right or
+// left to move selection.
+TEST_F(OverviewGestureHandlerTest, VerticalThenHorizontalSwipe) {
+  gfx::Rect bounds(0, 0, 400, 400);
+  aura::Window* root_window = Shell::GetPrimaryRootWindow();
+  std::unique_ptr<aura::Window> window1(CreateWindow(bounds));
+  std::unique_ptr<aura::Window> window2(CreateWindow(bounds));
+  std::unique_ptr<aura::Window> window3(CreateWindow(bounds));
+  std::unique_ptr<aura::Window> window4(CreateWindow(bounds));
+  std::unique_ptr<aura::Window> window5(CreateWindow(bounds));
+  ui::test::EventGenerator generator(root_window, root_window);
+  generator.ScrollSequence(gfx::Point(), base::TimeDelta::FromMilliseconds(5),
+                           0, -500, 100, 3);

[tdanderson, 2017/02/06 20:13:58]

nit: It might be nice to make use of kVerticalSwipeThresholdPixels here (and
similarly kHorizontalSwipeThresholdPixels elsewhere in this test) instead of
magic numbers.

[varkha, 2017/02/08 20:41:13]

Done.

+  EXPECT_TRUE(IsSelecting());
+
+  // Long swipe right moves selection to the fourth window.

[tdanderson, 2017/02/06 20:13:58]

Consider adding a test to verify that horizontal three-finger scrolling is a
no-op in overview mode if you didn't initiate overview from three-finger scroll
upwards. (Or come to think of it, maybe we would want three-finger horizontal
scroll to always have the same behavior?)

[varkha, 2017/02/08 20:41:13]

(Or come to think of it, maybe we would want three-finger horizontal scroll to
always have the same behavior?
^^ this ^^

+  generator.ScrollSequence(gfx::Point(), base::TimeDelta::FromMilliseconds(5),
+                           500, 0, 100, 3);
+  EXPECT_TRUE(IsSelecting());
+
+  // Short swipe left moves selection to the third window.
+  generator.ScrollSequence(gfx::Point(), base::TimeDelta::FromMilliseconds(5),
+                           -200, 0, 100, 3);
+  EXPECT_TRUE(IsSelecting());
+
+  // Short swipe left moves selection to the second window.
+  generator.ScrollSequence(gfx::Point(), base::TimeDelta::FromMilliseconds(5),
+                           -150, 0, 100, 3);
+  EXPECT_TRUE(IsSelecting());
+
+  // Swiping down exits.

[tdanderson, 2017/02/06 20:13:58]

nit: swiping down exists and selects the currently-highlighted window.

[varkha, 2017/02/08 20:41:13]

Done.

+  generator.ScrollSequence(gfx::Point(), base::TimeDelta::FromMilliseconds(5),
+                           0, 500, 100, 3);
+  EXPECT_FALSE(IsSelecting());
+
+  // Second MRU window is selected (i.e. |window4|).
+  EXPECT_EQ(window4.get(), wm::GetActiveWindow());
+}
+
 // Tests that a mostly horizontal swipe does not trigger overview.
 TEST_F(OverviewGestureHandlerTest, HorizontalSwipes) {
   gfx::Rect bounds(0, 0, 400, 400);
   aura::Window* root_window = Shell::GetPrimaryRootWindow();
   std::unique_ptr<aura::Window> window1(CreateWindow(bounds));
   std::unique_ptr<aura::Window> window2(CreateWindow(bounds));
   ui::test::EventGenerator generator(root_window, root_window);
   generator.ScrollSequence(gfx::Point(), base::TimeDelta::FromMilliseconds(5),
                            600, -500, 100, 3);
   EXPECT_FALSE(IsSelecting());
@@ skipping 37 matching lines @@
     generator.Dispatch(&move);
   }
 
   EXPECT_FALSE(IsSelecting());
   ui::ScrollEvent fling_start(ui::ET_SCROLL_FLING_START, start, timestamp, 0, 0,
                               10, 0, 10, num_fingers);
   generator.Dispatch(&fling_start);
 }
 
 }  // namespace ash