third_party/WebKit/Source/web/WebViewImpl.h - Issue 2667283007: Refactor Samsung SmartClip implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2667283007: Refactor Samsung SmartClip implementation. (Closed)

Patch Set: Really apply code review comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewImpl.h

diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h

index f648bad5821d61114ab5a16616c68c213bc50c01..68d6129399d2163c5e5a76ea6852180ab8f8f322 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.h

+++ b/third_party/WebKit/Source/web/WebViewImpl.h

@@ -250,7 +250,6 @@ class WEB_EXPORT WebViewImpl final

void performCustomContextMenuAction(unsigned action) override;

void showContextMenu() override;

void didCloseContextMenu() override;

- void extractSmartClipData(WebRect, WebString&, WebString&, WebRect&) override;

void hidePopups() override;

void setPageOverlayColor(WebColor) override;

WebPageImportanceSignals* pageImportanceSignals() override;