third_party/WebKit/Source/web/WebLocalFrameImpl.h - Issue 2667283007: Refactor Samsung SmartClip implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.h

Issue 2667283007: Refactor Samsung SmartClip implementation. (Closed)

Patch Set: Really apply code review comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.h

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.h b/third_party/WebKit/Source/web/WebLocalFrameImpl.h

index 288cee89ad4441bfe0efe1c6285874e646f012df..5c8a850034753b73c6615c4d46f5ec2dbe4b9627 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.h

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.h

@@ -298,6 +298,10 @@ class WEB_EXPORT WebLocalFrameImpl final

base::SingleThreadTaskRunner* unthrottledTaskRunner() override;

WebInputMethodControllerImpl* inputMethodController() const override;

+ void extractSmartClipData(WebRect rectInViewport,

+ WebString& clipText,

+ WebString& clipHtml) override;

// WebFrameImplBase methods:

void initializeCoreFrame(FrameHost*,

FrameOwner*,