content/renderer/render_frame_impl.h - Issue 2667283007: Refactor Samsung SmartClip implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 2667283007: Refactor Samsung SmartClip implementation. (Closed)

Patch Set: Really apply code review comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index f4829ef6c738a1fc37b6562a75a5aed4110bb230..868be8228f9e6b34dd57dc147e0d5b4938dc4e15 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -874,6 +874,7 @@ class CONTENT_EXPORT RenderFrameImpl

void OnFocusedFormFieldDataRequest(int request_id);

void OnSetAccessibilityMode(AccessibilityMode new_mode);

void OnSnapshotAccessibilityTree(int callback_id);

+ void OnExtractSmartClipData(uint32_t callback_id, const gfx::Rect& rect);

void OnUpdateOpener(int opener_routing_id);

void OnDidUpdateSandboxFlags(blink::WebSandboxFlags flags);

void OnSetFrameOwnerProperties(