Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/SmartClipProviderTest.java

Issue 2667283007: Refactor Samsung SmartClip implementation. (Closed)
Patch Set: Really apply code review comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/SmartClipProviderTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/SmartClipProviderTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/SmartClipProviderTest.java
index c0e24a8046107654a9922d62e297f65b10058de7..3d522cefbeeaacbdff78cbf649399e063627b567 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/SmartClipProviderTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/SmartClipProviderTest.java
@@ -7,7 +7,6 @@ package org.chromium.chrome.browser;
import android.annotation.TargetApi;
import android.content.pm.ApplicationInfo;
import android.content.pm.PackageManager;
-import android.graphics.Rect;
import android.os.Build;
import android.os.Bundle;
import android.os.Handler;
@@ -54,16 +53,11 @@ public class SmartClipProviderTest
return mHtml;
}
- public Rect getRect() {
- return mRect;
- }
-
- public void notifyCalled(String title, String url, String text, String html, Rect rect) {
+ public void notifyCalled(String title, String url, String text, String html) {
mTitle = title;
mUrl = url;
mText = text;
mHtml = html;
- mRect = rect;
super.notifyCalled();
}
@@ -71,7 +65,6 @@ public class SmartClipProviderTest
private String mUrl;
private String mText;
private String mHtml;
- private Rect mRect;
}
private ChromeActivity mActivity;
@@ -132,9 +125,8 @@ public class SmartClipProviderTest
String title = bundle.getString("title");
String text = bundle.getString("text");
String html = bundle.getString("html");
- Rect rect = bundle.getParcelable("rect");
// We don't care about other values for now.
- mCallbackHelper.notifyCalled(title, url, text, html, rect);
+ mCallbackHelper.notifyCalled(title, url, text, html);
return true;
}
@@ -191,6 +183,5 @@ public class SmartClipProviderTest
assertEquals("about:blank", mCallbackHelper.getUrl());
assertNotNull(mCallbackHelper.getText());
assertNotNull(mCallbackHelper.getHtml());
- assertNotNull(mCallbackHelper.getRect());
}
}

Powered by Google App Engine
This is Rietveld 408576698