Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4246)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

Issue 2667283007: Refactor Samsung SmartClip implementation. (Closed)
Patch Set: Move FrameMsg Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
index 3a88d09ef28c20c6cec3a644dd780c51a3a7cc01..e4c3de2f19ed3e6e771db2b15dafb49048585158 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
@@ -100,7 +100,6 @@ public class CompositorViewHolder extends FrameLayout
private ChromeFullscreenManager mFullscreenManager;
private View mAccessibilityView;
private CompositorAccessibilityProvider mNodeProvider;
- private float mLastContentOffset;
/** The toolbar control container. **/
private ControlContainer mControlContainer;
@@ -455,7 +454,6 @@ public class CompositorViewHolder extends FrameLayout
*/
public void onStart() {
if (mFullscreenManager != null) {
- mLastContentOffset = mFullscreenManager.getContentOffset();
mFullscreenManager.addListener(this);
}
requestRender();
@@ -470,7 +468,6 @@ public class CompositorViewHolder extends FrameLayout
@Override
public void onContentOffsetChanged(float offset) {
- mLastContentOffset = offset;
onViewportChanged();
}
@@ -518,10 +515,6 @@ public class CompositorViewHolder extends FrameLayout
}
private void onViewportChanged() {
- // TODO(changwan): check if this can be merged with setContentMotionEventOffsets.
- if (mTabVisible != null && mTabVisible.getContentViewCore() != null) {
- mTabVisible.getContentViewCore().setSmartClipOffsets(0, (int) -mLastContentOffset);
- }
if (mLayoutManager != null) mLayoutManager.onViewportChanged();
}
@@ -678,7 +671,6 @@ public class CompositorViewHolder extends FrameLayout
public void setFullscreenHandler(ChromeFullscreenManager fullscreen) {
mFullscreenManager = fullscreen;
if (mFullscreenManager != null) {
- mLastContentOffset = mFullscreenManager.getContentOffset();
mFullscreenManager.addListener(this);
}
onViewportChanged();

Powered by Google App Engine
This is Rietveld 408576698