Adding a parameter for previews NQE triggering threshold

components/previews/core/previews_experiments.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/previews/core/previews_experiments.h"
 
 #include <map>
 #include <string>
 
 #include "base/logging.h"
@@ skipping 46 matching lines @@
 
 // The amount of time after any opt out that no previews should be shown.
 const char kSingleOptOutDurationInSeconds[] =
     "single_opt_out_duration_in_seconds";
 
 // The amount of time that an offline page is considered fresh enough to be
 // shown as a preview.
 const char kOfflinePreviewFreshnessDurationInDays[] =
     "offline_preview_freshness_duration_in_days";
 
+// The threshold of EffectiveConnectionType above which previews will not be
+// served.
+// See net/nqe/effective_connection_type.h for mapping from int to value.
+const char kEffectiveConnectionTypeThreshold[] =
+    "max_allowed_effective_connection_type";
+
 // The string that corresponds to enabled for the variation param experiments.
 const char kExperimentEnabled[] = "true";
 
 // Returns the parameter value of |param| as a string. If there is no value for
 // |param|, returns an empty string.
 std::string ParamValue(const std::string& param) {
   if (!IsIncludedInClientSidePreviewsExperimentsFieldTrial())
     return std::string();
   std::map<std::string, std::string> experiment_params;
   if (!variations::GetVariationParams(kClientSidePreviewsFieldTrial,
@@ skipping 74 matching lines @@
 }
 
 base::TimeDelta OfflinePreviewFreshnessDuration() {
   std::string param_value = ParamValue(kOfflinePreviewFreshnessDurationInDays);
   int duration;
   if (!base::StringToInt(param_value, &duration))
     duration = 7;
   return base::TimeDelta::FromDays(duration);
 }
 
+net::EffectiveConnectionType EffectiveConnectionTypeThreshold() {
+  std::string param_value = ParamValue(kEffectiveConnectionTypeThreshold);
+  int effective_type_value;
+  if (!base::StringToInt(param_value, &effective_type_value)) {

[tbansal1, 2017/02/02 00:13:40]

You may want to use this function:
https://cs.chromium.org/chromium/src/net/nqe/effective_connection_type.cc?rcl...
if you prefer a more descriptive name in the config files.

[RyanSturm, 2017/02/02 00:22:28]

Done. Thanks.

+    effective_type_value =

[tbansal1, 2017/02/02 00:13:40]

Instead of 2 static casts, may be just return E_C_T_SLOW2G here.

[RyanSturm, 2017/02/02 00:22:28]

Acknowledged.

+        static_cast<int>(net::EFFECTIVE_CONNECTION_TYPE_SLOW_2G);
+  }
+  return static_cast<net::EffectiveConnectionType>(effective_type_value);
+}
+
 }  // namespace params
 
 bool IsIncludedInClientSidePreviewsExperimentsFieldTrial() {
   // By convention, an experiment in the client-side previews study enables use
   // of at least one client-side previews optimization if its name begins with
   // "Enabled."
   return base::StartsWith(
       base::FieldTrialList::FindFullName(kClientSidePreviewsFieldTrial),
       kEnabled, base::CompareCase::SENSITIVE);
 }
@@ skipping 11 matching lines @@
 bool EnableOfflinePreviewsForTesting() {
   std::map<std::string, std::string> params;
   params[kOfflinePagesSlowNetwork] = kExperimentEnabled;
   return variations::AssociateVariationParams(kClientSidePreviewsFieldTrial,
                                               kEnabled, params) &&
          base::FieldTrialList::CreateFieldTrial(kClientSidePreviewsFieldTrial,
                                                 kEnabled);
 }
 
 }  // namespace previews