Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 266723016: aw: Fix a few missing initializers (Closed)

Created:
6 years, 7 months ago by boliu
Modified:
6 years, 7 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

aw: Fix a few missing initializers BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268290

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M android_webview/browser/browser_view_renderer.cc View 1 chunk +3 lines, -1 line 3 comments Download
M android_webview/browser/shared_renderer_state.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
boliu
Tiny patch. ptal
6 years, 7 months ago (2014-05-05 16:47:18 UTC) #1
hush (inactive)
https://codereview.chromium.org/266723016/diff/1/android_webview/browser/browser_view_renderer.cc File android_webview/browser/browser_view_renderer.cc (right): https://codereview.chromium.org/266723016/diff/1/android_webview/browser/browser_view_renderer.cc#newcode119 android_webview/browser/browser_view_renderer.cc:119: num_bytes_(0u) { right now, BVR does not need these ...
6 years, 7 months ago (2014-05-05 17:10:05 UTC) #2
boliu
https://codereview.chromium.org/266723016/diff/1/android_webview/browser/browser_view_renderer.cc File android_webview/browser/browser_view_renderer.cc (right): https://codereview.chromium.org/266723016/diff/1/android_webview/browser/browser_view_renderer.cc#newcode119 android_webview/browser/browser_view_renderer.cc:119: num_bytes_(0u) { On 2014/05/05 17:10:06, hush(OOO till May 28) ...
6 years, 7 months ago (2014-05-05 17:11:46 UTC) #3
hush (inactive)
https://codereview.chromium.org/266723016/diff/1/android_webview/browser/browser_view_renderer.cc File android_webview/browser/browser_view_renderer.cc (right): https://codereview.chromium.org/266723016/diff/1/android_webview/browser/browser_view_renderer.cc#newcode119 android_webview/browser/browser_view_renderer.cc:119: num_bytes_(0u) { OK. On 2014/05/05 17:11:46, boliu wrote: > ...
6 years, 7 months ago (2014-05-05 17:25:07 UTC) #4
boliu
Michael?
6 years, 7 months ago (2014-05-05 18:12:23 UTC) #5
michaelbai
lgtm
6 years, 7 months ago (2014-05-05 18:16:32 UTC) #6
boliu
The CQ bit was checked by boliu@chromium.org
6 years, 7 months ago (2014-05-05 18:18:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/266723016/1
6 years, 7 months ago (2014-05-05 18:20:02 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 22:04:21 UTC) #9
Message was sent while issue was closed.
Change committed as 268290

Powered by Google App Engine
This is Rietveld 408576698