Issue 2667213002: Get ModelTypeStoreFactory for reading list from ProfileSyncService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2667213002: Get ModelTypeStoreFactory for reading list from ProfileSyncService (Closed)

Created:
3 years, 10 months ago by pavely

Modified:
3 years, 10 months ago

Reviewers:
Olivier

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

More Reviews

Description

Get ModelTypeStoreFactory for reading list from ProfileSyncService This CL switches ReadingListModelFactory to using ProfileSyncService's factory for ModelTypeStore. This allows ReadingList to share store with other types. R=olivierrobin@chromium.org BUG=664920 Review-Url: https://codereview.chromium.org/2663553003 Cr-Commit-Position: refs/heads/master@{#447390} (cherry picked from commit 9d905484261b3bf9205c65d95b86f306914a8581)

Patch Set 1 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -12 lines)			Patch
M	ios/chrome/browser/reading_list/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ios/chrome/browser/reading_list/reading_list_model_factory.cc	View	3 chunks	+8 lines, -11 lines	0 comments	Download
M	ios/chrome/browser/sync/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ios/chrome/browser/tabs/tab_model_order_controller_unittest.mm	View	3 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pavely

3 years, 10 months ago (2017-02-01 23:07:23 UTC) #1

Description was changed from

==========
Get ModelTypeStoreFactory for reading list from ProfileSyncService

This CL switches ReadingListModelFactory to using ProfileSyncService's factory
for ModelTypeStore. This allows ReadingList to share store with other types.

R=olivierrobin@chromium.org
BUG=664920

Review-Url: https://codereview.chromium.org/2663553003
Cr-Commit-Position: refs/heads/master@{#447390}
(cherry picked from commit 9d905484261b3bf9205c65d95b86f306914a8581)
==========

to

==========
Get ModelTypeStoreFactory for reading list from ProfileSyncService

This CL switches ReadingListModelFactory to using ProfileSyncService's factory
for ModelTypeStore. This allows ReadingList to share store with other types.

R=olivierrobin@chromium.org
BUG=664920

Review-Url: https://codereview.chromium.org/2663553003
Cr-Commit-Position: refs/heads/master@{#447390}
(cherry picked from commit 9d905484261b3bf9205c65d95b86f306914a8581)
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages