Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 266713011: Revert "[Resources] Change the 38x31 avatars into 38x38 square ones." (Closed)

Created:
6 years, 7 months ago by noms (inactive)
Modified:
6 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert "[Resources] Change the 38x31 avatars into 38x38 square ones." This reverts r265714 (originally landed in https://codereview.chromium.org/225813006/) The square avatars cause regressions on the tab strip/shortcut manager. BUG=337986 R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267859

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -78 lines) Patch
M chrome/app/theme/chrome_unscaled_resources.grd View 1 chunk +26 lines, -26 lines 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_alien.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_alien_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_awesome.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_awesome_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_burger.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_burger_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_businessman.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_businessman_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_cat.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_cat_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_cupcake.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_cupcake_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_dog.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_dog_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_flower.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_flower_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_generic.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_generic_aqua.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_generic_aqua_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_generic_blue.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_generic_blue_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_generic_green.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_generic_green_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_generic_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_generic_orange.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_generic_orange_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_generic_purple.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_generic_purple_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_generic_red.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_generic_red_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_generic_yellow.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_generic_yellow_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_horse.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_horse_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_margarita.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_margarita_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_ninja.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_ninja_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_note.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_note_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_pizza.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_pizza_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_secret_agent.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_secret_agent_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_soccer.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_soccer_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_sun_cloud.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_sun_cloud_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_superhero.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_superhero_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_volley_ball.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/profile_avatar_volley_ball_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_alien.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_alien_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_awesome.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_awesome_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_burger.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_burger_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_businessman.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_businessman_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_cat.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_cat_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_cupcake.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_cupcake_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_dog.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_dog_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_flower.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_flower_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_generic.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_generic_aqua.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_generic_aqua_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_generic_blue.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_generic_blue_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_generic_green.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_generic_green_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_generic_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_generic_orange.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_generic_orange_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_generic_purple.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_generic_purple_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_generic_red.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_generic_red_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_generic_yellow.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_generic_yellow_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_horse.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_horse_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_margarita.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_margarita_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_ninja.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_ninja_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_note.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_note_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_pizza.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_pizza_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_secret_agent.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_secret_agent_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_soccer.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_soccer_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_sun_cloud.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_sun_cloud_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_superhero.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_superhero_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_volley_ball.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/profile_avatar_volley_ball_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_alien.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_alien_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_awesome.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_awesome_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_burger.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_burger_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_businessman.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_businessman_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_cat.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_cat_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_cupcake.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_cupcake_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_dog.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_dog_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_flower.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_flower_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_generic.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_generic_aqua.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_generic_aqua_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_generic_blue.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_generic_blue_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_generic_green.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_generic_green_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_generic_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_generic_orange.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_generic_orange_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_generic_purple.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_generic_purple_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_generic_red.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_generic_red_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_generic_yellow.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_generic_yellow_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_horse.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_horse_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_margarita.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_margarita_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_ninja.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_ninja_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_note.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_note_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_pizza.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_pizza_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_secret_agent.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_secret_agent_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_soccer.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_soccer_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_sun_cloud.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_sun_cloud_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_superhero.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_superhero_mac.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_volley_ball.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/profile_avatar_volley_ball_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_alien.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_alien_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_awesome.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_awesome_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_burger.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_burger_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_businessman.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_businessman_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_cat.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_cat_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_cupcake.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_cupcake_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_dog.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_dog_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_flower.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_flower_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_generic.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_generic_aqua.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_generic_aqua_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_generic_blue.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_generic_blue_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_generic_green.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_generic_green_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_generic_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_generic_orange.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_generic_orange_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_generic_purple.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_generic_purple_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_generic_red.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_generic_red_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_generic_yellow.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_generic_yellow_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_horse.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_horse_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_margarita.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_margarita_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_ninja.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_ninja_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_note.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_note_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_pizza.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_pizza_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_secret_agent.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_secret_agent_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_soccer.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_soccer_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_sun_cloud.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_sun_cloud_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_superhero.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_superhero_mac.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_volley_ball.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/profile_avatar_volley_ball_mac.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +52 lines, -52 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
noms (inactive)
6 years, 7 months ago (2014-05-02 17:15:35 UTC) #1
oshima
lgtm
6 years, 7 months ago (2014-05-02 17:20:39 UTC) #2
noms (inactive)
6 years, 7 months ago (2014-05-02 17:56:43 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r267859 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698