Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 266703003: Non-SFI NaCl: Expose the "fdio" IRT interface via its non-dev query string (Closed)

Created:
6 years, 7 months ago by Mark Seaborn
Modified:
6 years, 7 months ago
Reviewers:
hidehiko
CC:
chromium-reviews, hamaji, mazda
Visibility:
Public.

Description

Non-SFI NaCl: Expose the "fdio" IRT interface via its non-dev query string For PNaCl, "fdio" should only be exposed via the "dev" query string, indicating a non-stable interface. But, outside of PNaCl, since we will be providing open_resource() as a stable interface in Non-SFI NaCl, we need to provide "fdio" as a stable ABI, via its non-dev query string. Since open_resource() returns an FD, it's only useful with the FD operations that "fdio" provides. BUG=358431 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268240

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/nacl/loader/nonsfi/irt_interfaces.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Mark Seaborn
6 years, 7 months ago (2014-05-02 20:52:45 UTC) #1
hidehiko
lgtm
6 years, 7 months ago (2014-05-05 12:37:00 UTC) #2
Mark Seaborn
The CQ bit was checked by mseaborn@chromium.org
6 years, 7 months ago (2014-05-05 13:53:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/266703003/1
6 years, 7 months ago (2014-05-05 13:53:33 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-05 17:29:17 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 19:10:33 UTC) #6
Message was sent while issue was closed.
Change committed as 268240

Powered by Google App Engine
This is Rietveld 408576698