Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2667023003: Update average times for perf desktop benchmarks

Created:
3 years, 10 months ago by martiniss
Modified:
3 years, 10 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update average times for perf desktop benchmarks BUG=687425

Patch Set 1 #

Patch Set 2 : Reparent on regeneration #

Patch Set 3 : Regenerate again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1508 lines, -1111 lines) Patch
M testing/buildbot/chromium.perf.fyi.json View 1 2 1110 chunks +1110 lines, -1110 lines 0 comments Download
M tools/perf/desktop_benchmark_avg_times.json View 1 2 1 chunk +398 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 3 (1 generated)
sullivan
lgtm The intent of this CL lgtm. It's really hard to actually get a diff ...
3 years, 10 months ago (2017-02-01 15:41:54 UTC) #2
martiniss
3 years, 10 months ago (2017-02-02 19:21:21 UTC) #3
On 2017/02/01 at 15:41:54, sullivan wrote:
> lgtm
> 
> The intent of this CL lgtm.
> 
> It's really hard to actually get a diff of the JSON to verify that the times
seem sane, there's no stray commas, etc. Is this covered by some kind of tests
(for example, would it submit if the json was invalid?)

I'm holding off on submitting this CL until I can generate some kind of diff,
since I am also worried about this possibility. I also want to be able to put
some sort of info in the description about what the affected benchmarks will be.

Powered by Google App Engine
This is Rietveld 408576698