WIP: Fix WebIDL spec violation: prototype names end with "Prototype".

third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 15 matching lines @@
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "bindings/core/v8/V8DOMConfiguration.h"
 
 #include "bindings/core/v8/GeneratedCodeHelper.h"  // just for DCHECK
 #include "bindings/core/v8/V8ObjectConstructor.h"
 #include "bindings/core/v8/V8PerContextData.h"
 #include "platform/instrumentation/tracing/TraceEvent.h"
 
+#include <string>
+
 namespace blink {
 
 namespace {
 
 void installAttributeInternal(
     v8::Isolate* isolate,
     v8::Local<v8::ObjectTemplate> instanceTemplate,
     v8::Local<v8::ObjectTemplate> prototypeTemplate,
     const V8DOMConfiguration::AttributeConfiguration& attribute,
     const DOMWrapperWorld& world) {
@@ skipping 562 matching lines @@
     v8::Local<v8::FunctionTemplate> interfaceTemplate,
     const char* interfaceName,
     v8::Local<v8::FunctionTemplate> parentInterfaceTemplate,
     size_t v8InternalFieldCount) {
   interfaceTemplate->SetClassName(v8AtomicString(isolate, interfaceName));
   interfaceTemplate->ReadOnlyPrototype();
   v8::Local<v8::ObjectTemplate> instanceTemplate =
       interfaceTemplate->InstanceTemplate();
   v8::Local<v8::ObjectTemplate> prototypeTemplate =
       interfaceTemplate->PrototypeTemplate();
-  instanceTemplate->SetInternalFieldCount(v8InternalFieldCount);
-  // TODO(yukishiino): We should set the class string to the platform object
-  // (|instanceTemplate|), too.  The reason that we don't set it is that
-  // it prevents minor GC to collect unreachable DOM objects (a layout test
+  // TODO(mgiuca): Setting the class string for |instanceTemplate| prevents
+  // minor GC from collecting unreachable DOM objects (a layout test
   // fast/dom/minor-dom-gc.html fails if we set the class string).

[haraken, 2017/02/01 03:57:12]

yukishiino@: Is this still true? We've made a lot of changes to the minor GC
algorithm, so we might want to check if that is still a problem or not.

[Matt Giuca, 2017/02/01 03:59:47]

I just tried it and it fails under this CL.

   // See also http://heycam.github.io/webidl/#es-platform-objects
-  setClassString(isolate, prototypeTemplate, interfaceName);
+  // However, *not* setting this means that setting the class string for
+  // |prototypeTemplate| below causes instances to also be named "Prototype".
+  // See https://crbug.com/687431.
+  // DO NOT SUBMIT.
+  setClassString(isolate, instanceTemplate, interfaceName);
+  instanceTemplate->SetInternalFieldCount(v8InternalFieldCount);
+  std::string prototypeName(interfaceName);
+  prototypeName += "Prototype";
+  setClassString(isolate, prototypeTemplate, prototypeName.c_str());
   if (!parentInterfaceTemplate.IsEmpty()) {
     interfaceTemplate->Inherit(parentInterfaceTemplate);
     // Marks the prototype object as one of native-backed objects.
     // This is needed since bug 110436 asks WebKit to tell native-initiated
     // prototypes from pure-JS ones.  This doesn't mark kinds "root" classes
     // like Node, where setting this changes prototype chain structure.
     prototypeTemplate->SetInternalFieldCount(v8PrototypeInternalFieldcount);
   }
 }
 
@@ skipping 18 matching lines @@
 void V8DOMConfiguration::setClassString(
     v8::Isolate* isolate,
     v8::Local<v8::ObjectTemplate> objectTemplate,
     const char* classString) {
   objectTemplate->Set(
       v8::Symbol::GetToStringTag(isolate), v8AtomicString(isolate, classString),
       static_cast<v8::PropertyAttribute>(v8::ReadOnly | v8::DontEnum));
 }
 
 }  // namespace blink