Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: ui/keyboard/keyboard_event_filter.h

Issue 2666843003: Disable pinch-to-zoom gesture on virtual keyboard (Closed)
Patch Set: add a comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/keyboard/keyboard_event_filter.h
diff --git a/ui/keyboard/keyboard_event_filter.h b/ui/keyboard/keyboard_event_filter.h
new file mode 100644
index 0000000000000000000000000000000000000000..213e0e57b3e6b72512d990168a233e98a1bc8749
--- /dev/null
+++ b/ui/keyboard/keyboard_event_filter.h
@@ -0,0 +1,30 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_KEYBOARD_KEYBOARD_EVENT_FILTER_H_
+#define UI_KEYBOARD_KEYBOARD_EVENT_FILTER_H_
+
+#include "base/macros.h"
+#include "ui/events/event_handler.h"
+#include "ui/keyboard/keyboard_export.h"
+
+namespace keyboard {
+
+// EventFilter for the keyboard window, which intercepts events before they are
+// processed by the keyboard window and excludes pinch gesture events.
bshe 2017/01/31 16:39:25 "excludes pinch gesture events" doesn't feel like
yhanada 2017/02/01 02:48:31 I removed that part.
+class KEYBOARD_EXPORT KeyboardEventFilter : public ui::EventHandler {
+ public:
+ KeyboardEventFilter(){};
oshima 2017/01/31 21:06:53 space between ){. Did you run git cl format?
yhanada 2017/02/01 02:48:31 Yes. git cl format removes the spaces.
+ ~KeyboardEventFilter() override{};
bshe 2017/01/31 16:39:25 nit: use "= default"?
yhanada 2017/02/01 02:48:31 Done.
+
+ // ui::EventHandler overrides:
+ void OnGestureEvent(ui::GestureEvent* event) override;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(KeyboardEventFilter);
+};
+
+} // namespace keyboard
+
+#endif // UI_KEYBOARD_KEYBOARD_EVENT_FILTER_H_

Powered by Google App Engine
This is Rietveld 408576698